Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 13594011: Fix chromoting client crash. (Closed)

Created:
7 years, 8 months ago by Sergey Ulanov
Modified:
7 years, 8 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Fix chromoting client crash. The client plugin may crash if a signaling message is receive before the client started connection. It's likely to be a leftover from a previous session, so it's safe to ignore it. BUG=226775 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192923

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M remoting/client/plugin/chromoting_instance.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
7 years, 8 months ago (2013-04-06 00:34:56 UTC) #1
alexeypa (please no reviews)
lgtm https://codereview.chromium.org/13594011/diff/1/remoting/client/plugin/chromoting_instance.cc File remoting/client/plugin/chromoting_instance.cc (right): https://codereview.chromium.org/13594011/diff/1/remoting/client/plugin/chromoting_instance.cc#newcode619 remoting/client/plugin/chromoting_instance.cc:619: // Just ignore the message if it's received ...
7 years, 8 months ago (2013-04-08 15:55:28 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/13594011/diff/1/remoting/client/plugin/chromoting_instance.cc File remoting/client/plugin/chromoting_instance.cc (right): https://codereview.chromium.org/13594011/diff/1/remoting/client/plugin/chromoting_instance.cc#newcode619 remoting/client/plugin/chromoting_instance.cc:619: // Just ignore the message if it's received before ...
7 years, 8 months ago (2013-04-08 19:48:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/13594011/4001
7 years, 8 months ago (2013-04-08 19:48:23 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-08 22:12:01 UTC) #5
Message was sent while issue was closed.
Change committed as 192923

Powered by Google App Engine
This is Rietveld 408576698