Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5765)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h

Issue 135933003: rAc: split TestableAutofillDialogView implementation into its own class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: with mac nits fixed Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h b/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h
index 37119f9b271c6e652f72d8fdca520f6e624e92d3..30ffe735a2bebc93674e304bfb967cf016f0a21f 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h
+++ b/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h
@@ -10,7 +10,6 @@
#include "base/memory/weak_ptr.h"
#include "chrome/browser/ui/autofill/autofill_dialog_types.h"
#include "chrome/browser/ui/autofill/autofill_dialog_view.h"
-#include "chrome/browser/ui/autofill/testable_autofill_dialog_view.h"
#include "chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h"
#include "ui/gfx/size.h"
@@ -20,6 +19,7 @@ class NavigationController;
namespace autofill {
class AutofillDialogViewDelegate;
+class AutofillDialogViewTesterCocoa;
}
@class AutofillDialogWindowController;
@@ -27,7 +27,6 @@ class AutofillDialogViewDelegate;
namespace autofill {
class AutofillDialogCocoa : public AutofillDialogView,
- public TestableAutofillDialogView,
public ConstrainedWindowMacDelegate {
public:
explicit AutofillDialogCocoa(AutofillDialogViewDelegate* delegate);
@@ -57,25 +56,8 @@ class AutofillDialogCocoa : public AutofillDialogView,
virtual const content::NavigationController* ShowSignIn() OVERRIDE;
virtual void HideSignIn() OVERRIDE;
virtual void ModelChanged() OVERRIDE;
- virtual TestableAutofillDialogView* GetTestableView() OVERRIDE;
virtual void OnSignInResize(const gfx::Size& pref_size) OVERRIDE;
- // TestableAutofillDialogView implementation:
- // TODO(groby): Create a separate class to implement the testable interface:
- // http://crbug.com/256864
- virtual void SubmitForTesting() OVERRIDE;
- virtual void CancelForTesting() OVERRIDE;
- virtual base::string16 GetTextContentsOfInput(ServerFieldType type) OVERRIDE;
- virtual void SetTextContentsOfInput(ServerFieldType type,
- const base::string16& contents) OVERRIDE;
- virtual void SetTextContentsOfSuggestionInput(
- DialogSection section,
- const base::string16& text) OVERRIDE;
- virtual void ActivateInput(ServerFieldType type) OVERRIDE;
- virtual gfx::Size GetSize() const OVERRIDE;
- virtual content::WebContents* GetSignInWebContents() OVERRIDE;
- virtual bool IsShowingOverlay() const OVERRIDE;
-
// ConstrainedWindowMacDelegate implementation:
virtual void OnConstrainedWindowClosed(
ConstrainedWindowMac* window) OVERRIDE;
@@ -86,6 +68,8 @@ class AutofillDialogCocoa : public AutofillDialogView,
void PerformClose();
private:
+ friend class AutofillDialogViewTesterCocoa;
+
// Closes the sheet and ends the modal loop. Triggers cleanup sequence.
void CloseNow();
« no previous file with comments | « chrome/browser/ui/autofill/testable_autofill_dialog_view.h ('k') | chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698