Crash on non-primary full screen exit

Crash on non-primary full screen exit


BUG=226132
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193289

[Harry McCleave, 2013-04-04 02:30:38]

Mind taking a look when you get a chance?

[oshima, 2013-04-04 08:03:21]

lgtm with nit.

https://codereview.chromium.org/13593006/diff/1001/ash/screen_ash_unittest.cc
File ash/screen_ash_unittest.cc (right):

https://codereview.chromium.org/13593006/diff/1001/ash/screen_ash_unittest.cc...
ash/screen_ash_unittest.cc:79: NULL, CurrentContext(), gfx::Rect(610, 10, 100,
100));
check if the secondary is indeed on 2nd display.
EXPECT_EQ(Shell::GetAllRootWindows[1],
secondary->GetNativewView()->GetRootWindow());

[commit-bot: I haz the power, 2013-04-04 19:24:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/13593006/7001

[commit-bot: I haz the power, 2013-04-04 19:24:21]

Presubmit check for 13593006-7001 failed and returned exit status 1.

INFO:root:Found 2 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ash/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    ash/screen_ash_unittest.cc

[James Cook, 2013-04-04 20:28:37]

LGTM including extending per-file ownership to oshima for tests

[commit-bot: I haz the power, 2013-04-04 20:29:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/13593006/11001

[commit-bot: I haz the power, 2013-04-04 20:31:57]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-04-05 20:39:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/13593006/11001

[commit-bot: I haz the power, 2013-04-08 18:12:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/13593006/11001

[commit-bot: I haz the power, 2013-04-08 18:38:39]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-08 21:49:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/13593006/33001

[commit-bot: I haz the power, 2013-04-08 22:22:00]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-09 03:34:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/13593006/41001

[commit-bot: I haz the power, 2013-04-09 06:27:49]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-04-09 22:33:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/13593006/40002

[commit-bot: I haz the power, 2013-04-10 02:11:23]

Change committed as 193289