Extract TabChromeWebContentsDelegateAndroid into a separate class.

Extract TabChromeWebContentsDelegateAndroid into a separate class.

BUG=532216
Committed: https://crrev.com/c42adedd646d50a54a467e0590160fe939f58ab6
Cr-Commit-Position: refs/heads/master@{#351464}

[aurimas (slooooooooow), 2015-09-21 23:54:43]

aurimas@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[aurimas (slooooooooow), 2015-09-21 23:54:44]

PTAL

[Maria, 2015-09-22 21:01:50]

https://chromiumcodereview.appspot.com/1358923002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabChromeWebContentsDelegateAndroid.java
(right):

https://chromiumcodereview.appspot.com/1358923002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabChromeWebContentsDelegateAndroid.java:44:
extends ChromeWebContentsDelegateAndroid {
What do you think about merging this class with
ChromeWebContentsDelegateAndroid? As far as I can tell this is the only subclass
and I have no idea what the distinction is here.

https://chromiumcodereview.appspot.com/1358923002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabChromeWebContentsDelegateAndroid.java:46:
private static final String TAG = "TabChromeWebContentsDelegateAndroid";
I think the presubmit will make you switch to using chrome Log instead of
android Log class, at which point this thing will have to start with cr_ and be
at most 21 characters.

https://chromiumcodereview.appspot.com/1358923002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabChromeWebContentsDelegateAndroid.java:51:

remove one newline

https://chromiumcodereview.appspot.com/1358923002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabChromeWebContentsDelegateAndroid.java:308:
mTab.getHandler().post(mCloseContentsRunnable);
I think instead of exposing tab's handler for this, we should just register a
separate handler for this class.

[aurimas (slooooooooow), 2015-09-22 22:44:46]

https://chromiumcodereview.appspot.com/1358923002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabChromeWebContentsDelegateAndroid.java
(right):

https://chromiumcodereview.appspot.com/1358923002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabChromeWebContentsDelegateAndroid.java:46:
private static final String TAG = "TabChromeWebContentsDelegateAndroid";
On 2015/09/22 at 21:01:50, Maria wrote:
> I think the presubmit will make you switch to using chrome Log instead of
android Log class, at which point this thing will have to start with cr_ and be
at most 21 characters.

Done

https://chromiumcodereview.appspot.com/1358923002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabChromeWebContentsDelegateAndroid.java:51:

On 2015/09/22 at 21:01:50, Maria wrote:
> remove one newline

Done

https://chromiumcodereview.appspot.com/1358923002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabChromeWebContentsDelegateAndroid.java:308:
mTab.getHandler().post(mCloseContentsRunnable);
On 2015/09/22 at 21:01:50, Maria wrote:
> I think instead of exposing tab's handler for this, we should just register a
separate handler for this class.

Done

[Maria, 2015-09-22 23:02:57]

https://chromiumcodereview.appspot.com/1358923002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabChromeWebContentsDelegateAndroid.java
(right):

https://chromiumcodereview.appspot.com/1358923002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabChromeWebContentsDelegateAndroid.java:94:
mTab.enableFullscreenAfterLoad();
already being handled in tab.

[aurimas (slooooooooow), 2015-09-22 23:16:49]

https://chromiumcodereview.appspot.com/1358923002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TabChromeWebContentsDelegateAndroid.java
(right):

https://chromiumcodereview.appspot.com/1358923002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/tab/TabChromeWebContentsDelegateAndroid.java:94:
mTab.enableFullscreenAfterLoad();
On 2015/09/22 at 23:02:57, Maria wrote:
> already being handled in tab.

Done

[Maria, 2015-09-22 23:23:47]

lgtm

https://chromiumcodereview.appspot.com/1358923002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java
(right):

https://chromiumcodereview.appspot.com/1358923002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java:129:
protected static native void nativeOnRendererUnresponsive(WebContents
webContents);
after you merge, you should also be able to reduce the visibility on these!

[aurimas (slooooooooow), 2015-09-22 23:40:19]

aurimas@chromium.org changed reviewers:
+ tedchoc@chromium.org

[aurimas (slooooooooow), 2015-09-22 23:40:20]

+tedchoc for chrome/browser/android OWNERS

[Ted C, 2015-09-22 23:47:07]

lgtm

[aurimas (slooooooooow), 2015-09-22 23:47:28]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-09-22 23:47:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358923002/40001

[commit-bot: I haz the power, 2015-09-23 05:23:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 05:23:44]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[aurimas (slooooooooow), 2015-09-30 00:01:50]

The CQ bit was checked by aurimas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-30 00:07:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358923002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358923002/60001

[aurimas (slooooooooow), 2015-09-30 00:16:43]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-09-30 00:16:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, mariakhomenko@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1358923002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-09-30 00:17:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2015-09-30 00:18:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358923002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358923002/80001

[commit-bot: I haz the power, 2015-09-30 00:25:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 00:25:48]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[aurimas (slooooooooow), 2015-09-30 01:03:45]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-09-30 01:04:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1358923002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1358923002/80001

[commit-bot: I haz the power, 2015-09-30 01:27:15]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-30 01:28:22]

Patchset 5 (id:??) landed as
https://crrev.com/c42adedd646d50a54a467e0590160fe939f58ab6
Cr-Commit-Position: refs/heads/master@{#351464}