Issue 13586012: drive: Enable a hook to update the default download directory.

Issue 13586012: drive: Enable a hook to update the default download directory. (Closed)

Created:
7 years, 8 months ago by Haruki Sato

Modified:
7 years, 8 months ago

Reviewers:
kinaba

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Enable a hook to update the default download directory. This enables the update logic for /drive/root namespace. BUG=174233 TESTS=unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192570

Patch Set 1 #

Patch Set 2 : update tests. #

Total comments: 2

Patch Set 3 : add comment. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -15 lines)			Patch
	M	chrome/browser/chromeos/drive/drive_file_system_util.cc	View	1 2	1 chunk	+12 lines, -10 lines	0 comments	Download
	M	chrome/browser/chromeos/drive/drive_file_system_util_unittest.cc	View	1	1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Haruki Sato

Could you take a brief look? I'd like to have it checked-in along with https://codereview.chromium.org/13149003/ ...

7 years, 8 months ago (2013-04-05 01:54:28 UTC) #1

kinaba

lgtm https://codereview.chromium.org/13586012/diff/1002/chrome/browser/chromeos/drive/drive_file_system_util.cc File chrome/browser/chromeos/drive/drive_file_system_util.cc (right): https://codereview.chromium.org/13586012/diff/1002/chrome/browser/chromeos/drive/drive_file_system_util.cc#newcode235 chrome/browser/chromeos/drive/drive_file_system_util.cc:235: return IsUnderDriveMountPoint(path) && Could you add a short ...

7 years, 8 months ago (2013-04-05 01:57:57 UTC) #2

Haruki Sato

https://codereview.chromium.org/13586012/diff/1002/chrome/browser/chromeos/drive/drive_file_system_util.cc File chrome/browser/chromeos/drive/drive_file_system_util.cc (right): https://codereview.chromium.org/13586012/diff/1002/chrome/browser/chromeos/drive/drive_file_system_util.cc#newcode235 chrome/browser/chromeos/drive/drive_file_system_util.cc:235: return IsUnderDriveMountPoint(path) && On 2013/04/05 01:57:58, kinaba wrote: > ...

7 years, 8 months ago (2013-04-05 04:43:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/13586012/6001

7 years, 8 months ago (2013-04-05 13:42:57 UTC) #4

Message was sent while issue was closed.

Change committed as 192570

Expand Messages | Collapse Messages