Remove unused themes on clicking the reset theme button

Remove unused themes on clicking the reset theme button

BUG=164675
TEST=Repro steps at http://crbug.com/164675

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192875

[ckocagil, 2013-04-03 22:25:21]

All theme infobars remove themselves when the theme is reset
(ThemeInstalledInfoBarDelegate::Observe). Since there are no infobars to require
keeping the installed themes, we can clean them up.

[pkotwicz, 2013-04-04 17:03:53]

LGTM, this change is a good one.

However, this bug is due to a memory leak wrt ThemeInstalledInfoBarDelegate and
this CL does not fix the memory leak.

https://codereview.chromium.org/13584007/diff/1/chrome/browser/themes/theme_s...
File chrome/browser/themes/theme_service.cc (right):

https://codereview.chromium.org/13584007/diff/1/chrome/browser/themes/theme_s...
chrome/browser/themes/theme_service.cc:243: RemoveUnusedThemes();
You should call RemoveUnusedThemes() at the end of ClearAllThemeData().
This way, you will remove the unused themes as a result of
GtkThemeService::SetNativeTheme() too.

[ckocagil, 2013-04-05 18:12:02]

I'm committing this now. I will fix the memory leak separately and verify that
it removes the themes without this patch.

https://codereview.chromium.org/13584007/diff/1/chrome/browser/themes/theme_s...
File chrome/browser/themes/theme_service.cc (right):

https://codereview.chromium.org/13584007/diff/1/chrome/browser/themes/theme_s...
chrome/browser/themes/theme_service.cc:243: RemoveUnusedThemes();
On 2013/04/04 17:03:53, pkotwicz wrote:
> You should call RemoveUnusedThemes() at the end of ClearAllThemeData().
> This way, you will remove the unused themes as a result of
> GtkThemeService::SetNativeTheme() too.

Done.

[commit-bot: I haz the power, 2013-04-05 18:41:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ckocagil@chromium.org/13584007/5001

[commit-bot: I haz the power, 2013-04-05 21:14:33]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[ckocagil, 2013-04-06 19:38:51]

jeremya: extension_install_ui_browsertest.cc

[jeremya, 2013-04-08 16:52:38]

Rubberstamp LGTM. I don't really know the code in question, but it seems okay to
me.

[commit-bot: I haz the power, 2013-04-08 17:54:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ckocagil@chromium.org/13584007/18001

[commit-bot: I haz the power, 2013-04-08 19:44:15]

Retried try job too often on mac_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-04-08 20:00:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ckocagil@chromium.org/13584007/18001

[commit-bot: I haz the power, 2013-04-08 20:15:29]

Change committed as 192875