Prioritize tiles near the viewport in out-of-viewport layers

cc/resources/picture_layer_tiling_unittest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/picture_layer_tiling.h"
 
 #include "cc/test/fake_picture_layer_tiling_client.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/rect_conversions.h"
 #include "ui/gfx/size_conversions.h"
@@ skipping 52 matching lines @@
     // The entire rect must be filled by geometry from the tiling.
     EXPECT_TRUE(remaining.IsEmpty());
   }
 
   void VerifyTilesExactlyCoverRect(float rect_scale, gfx::Rect rect) {
     VerifyTilesExactlyCoverRect(rect_scale, rect, rect);
   }
 
   void VerifyTiles(float rect_scale,
                    gfx::Rect rect,
-                   base::Callback<void(Tile*)> callback) {
+                   base::Callback<void(Tile* tile)> callback) {
     Region remaining = rect;
     for (PictureLayerTiling::CoverageIterator iter(
              tiling_.get(), rect_scale, rect);
          iter;
          ++iter) {
       remaining.Subtract(iter.geometry_rect());
       callback.Run(*iter);
     }
     EXPECT_TRUE(remaining.IsEmpty());
   }
@@ skipping 272 matching lines @@
       in, target_area, bounds);
   EXPECT_EQ(30, out.bottom() - in.bottom());
   EXPECT_EQ(50, in.y() - out.y());
   EXPECT_EQ(out.right() - in.right(), in.x() - out.x());
   EXPECT_LE(out.width() * out.height(), target_area);
   EXPECT_GT(out.width() * out.height(),
             target_area - out.height() * 2);
   EXPECT_TRUE(bounds.Contains(out));
 }
 
-TEST(PictureLayerTilingTest, ExpandRectOutOfBounds) {
-  gfx::Rect in(40, 50, 100, 200);
+TEST(PictureLayerTilingTest, ExpandRectOutOfBoundsFarAway) {
+  gfx::Rect in(400, 500, 100, 200);
   gfx::Rect bounds(0, 0, 10, 10);
   int64 target_area = 400 * 400;
   gfx::Rect out = PictureLayerTiling::ExpandRectEquallyToAreaBoundedBy(
       in, target_area, bounds);
   EXPECT_TRUE(out.IsEmpty());
 }
 
+TEST(PictureLayerTilingTest, ExpandRectOutOfBoundsExpandedFullyCover) {
+  gfx::Rect in(40, 50, 100, 100);
+  gfx::Rect bounds(0, 0, 10, 10);
+  int64 target_area = 400 * 400;
+  gfx::Rect out = PictureLayerTiling::ExpandRectEquallyToAreaBoundedBy(
+      in, target_area, bounds);
+  EXPECT_EQ(bounds.ToString(), out.ToString());
+}
+
+TEST(PictureLayerTilingTest, ExpandRectOutOfBoundsExpandedPartlyCover) {
+  gfx::Rect in(600, 600, 100, 100);
+  gfx::Rect bounds(0, 0, 500, 500);
+  int64 target_area = 400 * 400;
+  gfx::Rect out = PictureLayerTiling::ExpandRectEquallyToAreaBoundedBy(
+      in, target_area, bounds);
+  EXPECT_EQ(bounds.right(), out.right());
+  EXPECT_EQ(bounds.bottom(), out.bottom());
+  EXPECT_LE(out.width() * out.height(), target_area);
+  EXPECT_GT(out.width() * out.height(),
+            target_area - out.width() - out.height());
+  EXPECT_TRUE(bounds.Contains(out));
+}
+
 TEST(PictureLayerTilingTest, EmptyStartingRect) {
   // If a layer has a non-invertible transform, then the starting rect
   // for the layer would be empty.
   gfx::Rect in(40, 40, 0, 0);
   gfx::Rect bounds(0, 0, 10, 10);
   int64 target_area = 400 * 400;
   gfx::Rect out = PictureLayerTiling::ExpandRectEquallyToAreaBoundedBy(
       in, target_area, bounds);
   EXPECT_TRUE(out.IsEmpty());
 }
 
 static void TileExists(bool live, Tile* tile) {
   ASSERT_TRUE(tile != NULL);
   EXPECT_EQ(live, tile->priority(ACTIVE_TREE).is_live);
 }
 
 TEST_F(PictureLayerTilingIteratorTest, TilesExist) {
   gfx::Size layer_bounds(1099, 801);
   Initialize(gfx::Size(100, 100), 1.f, layer_bounds);
   VerifyTilesExactlyCoverRect(1.f, gfx::Rect(layer_bounds));
   VerifyTiles(1.f, gfx::Rect(layer_bounds), base::Bind(&TileExists, false));
 
   tiling_->UpdateTilePriorities(
       ACTIVE_TREE,
-      layer_bounds, // device viewport
-      gfx::Rect(layer_bounds), // viewport in layer space
-      layer_bounds, // last layer bounds
-      layer_bounds, // current layer bounds
-      1.f, // last contents scale
-      1.f, // current contents scale
-      gfx::Transform(), // last screen transform
-      gfx::Transform(), // current screen transform
-      1, // current frame number
-      1.0, // current frame time
-      false, // store screen space quads on tiles
-      10000); // max tiles in tile manager
+      layer_bounds,  // device viewport
+      gfx::Rect(layer_bounds),  // viewport in layer space
+      layer_bounds,  // last layer bounds
+      layer_bounds,  // current layer bounds
+      1.f,  // last contents scale
+      1.f,  // current contents scale
+      gfx::Transform(),  // last screen transform
+      gfx::Transform(),  // current screen transform
+      1,  // current frame number
+      1.0,  // current frame time
+      false,  // store screen space quads on tiles
+      10000);  // max tiles in tile manager
   VerifyTiles(1.f, gfx::Rect(layer_bounds), base::Bind(&TileExists, true));
 
   // Make the viewport rect empty. All tiles are killed and become zombies.
   tiling_->UpdateTilePriorities(
       ACTIVE_TREE,
-      layer_bounds, // device viewport
-      gfx::Rect(), // viewport in layer space
-      layer_bounds, // last layer bounds
-      layer_bounds, // current layer bounds
-      1.f, // last contents scale
-      1.f, // current contents scale
-      gfx::Transform(), // last screen transform
-      gfx::Transform(), // current screen transform
-      2, // current frame number
-      2.0, // current frame time
-      false, // store screen space quads on tiles
-      10000); // max tiles in tile manager
+      layer_bounds,  // device viewport
+      gfx::Rect(),  // viewport in layer space
+      layer_bounds,  // last layer bounds
+      layer_bounds,  // current layer bounds
+      1.f,  // last contents scale
+      1.f,  // current contents scale
+      gfx::Transform(),  // last screen transform
+      gfx::Transform(),  // current screen transform
+      2,  // current frame number
+      2.0,  // current frame time
+      false,  // store screen space quads on tiles
+      10000);  // max tiles in tile manager
   VerifyTiles(1.f, gfx::Rect(layer_bounds), base::Bind(&TileExists, false));
 }
 
 }  // namespace
 }  // namespace cc