cros: Explicitly manage app session lifetime.

cros: Explicitly manage app session lifetime.

- Remove the EndKeepALive work arounds;
- Manage app session lifetime explicitly by watching app
  window counts;

BUG=226103
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192487

[zel, 2013-04-03 22:17:50]

https://codereview.chromium.org/13581008/diff/1/chrome/browser/chromeos/app_m...
File chrome/browser/chromeos/app_mode/startup_app_launcher.cc (right):

https://codereview.chromium.org/13581008/diff/1/chrome/browser/chromeos/app_m...
chrome/browser/chromeos/app_mode/startup_app_launcher.cc:91: if
(shell_window->extension()->id() == app_id_)
are you sure that extension() isn't NULL?

what if identity API window pops up first?

https://codereview.chromium.org/13581008/diff/1/chrome/browser/chromeos/app_m...
chrome/browser/chromeos/app_mode/startup_app_launcher.cc:333:
base::Bind(&StartupAppLauncher::OnLaunchSuccess, AsWeakPtr())));
what happens if app never creates a window? are we going to be just hanging
there indefinitely?

[xiyuan, 2013-04-03 23:10:32]

Okay. The CL sounds like a bad idea.

The only reason we have EndKeepAlive is because we skipped it in
HandleAppExitingForPlatform. The code is added because we want to exit when last
app window is closed.

So a better approach seems to be that we don't skip EndKeepAlive in
HandleAppExitingForPlatform and add code to do the exit-on-last-app-window-close
explicitly.

[xiyuan, 2013-04-04 17:10:24]

Here is a cleaner solution that removes the EndKeepAlive work arounds and binds
the app session lifetime with app window counts explicitly.

Also moved the update restart setup code into the new InitAppSession.

+sky for application_lifetime_aura.cc and gyp.

[sky, 2013-04-04 17:39:42]

LGTM

[zel, 2013-04-04 17:44:43]

lgtm

[commit-bot: I haz the power, 2013-04-04 20:36:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/13581008/7001

[commit-bot: I haz the power, 2013-04-04 20:41:38]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-04-04 23:25:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/13581008/7001

[commit-bot: I haz the power, 2013-04-05 03:53:15]

Change committed as 192487