Issue 13579005: chromeos: Fix FilePath handling incompatibility between FakeDriveFileSystem::GetEntryInfoByResource…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13579005: chromeos: Fix FilePath handling incompatibility between FakeDriveFileSystem::GetEntryInfoByResource… (Closed)

Created:
7 years, 8 months ago by hashimoto

Modified:
7 years, 8 months ago

Reviewers:
hidehiko

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Fix FilePath handling incompatibility between FakeDriveFileSystem::GetEntryInfoByResourceId and GetEntryInfoByPath ConvertResourceEntryToDriveEntryProto adds extensions like ".gdoc" to hosted documents. GetEntryInfoByResourceId and GetEntryInfoByPath should handle paths in the same manner. BUG=None TEST=unit_tests --gtest_filter="FakeDriveFileSystemTest.GetEntryInfoByResourceId_PathCompatibleWithGetEntryInfoByPath" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192555

Patch Set 1 : _ #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -5 lines)			Patch
	M	chrome/browser/chromeos/drive/fake_drive_file_system.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download
	M	chrome/browser/chromeos/drive/fake_drive_file_system_unittest.cc	View		1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/13579005/3001

7 years, 8 months ago (2013-04-05 08:30:02 UTC) #3

Message was sent while issue was closed.

Change committed as 192555

Expand Messages | Collapse Messages