Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 13577005: cc: Prevent checkerboarded animations from timing out during tests. (Closed)

Created:
7 years, 8 months ago by danakj
Modified:
7 years, 8 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org, ajuma, piman, backer
Visibility:
Public.

Description

cc: Prevent checkerboarded animations from timing out during tests. During tests that verify behaviour with checkerboarding, we need preductable behaviour. Currently if the test takes too long and the compositor thread ticks too many times, the checkerboarded animation will time out and animate+draw. This is unpredictable flaky behaviour for the tests. So add a setting to disable this timeout-and-draw behaviour in the scheduler. R=jamesr BUG=228998 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193006

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M cc/scheduler/scheduler_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/scheduler/scheduler_settings.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
7 years, 8 months ago (2013-04-08 20:55:33 UTC) #1
jamesr
lgtm
7 years, 8 months ago (2013-04-09 00:09:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/13577005/4001
7 years, 8 months ago (2013-04-09 00:10:05 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-09 01:02:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/13577005/4001
7 years, 8 months ago (2013-04-09 02:44:22 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-09 04:37:35 UTC) #6
Message was sent while issue was closed.
Change committed as 193006

Powered by Google App Engine
This is Rietveld 408576698