Apply script preprocessor to Web page scripts only.

Source/core/inspector/PageDebuggerAgent.cpp

Index: Source/core/inspector/PageDebuggerAgent.cpp
diff --git a/Source/core/inspector/PageDebuggerAgent.cpp b/Source/core/inspector/PageDebuggerAgent.cpp
index 72bd983efa425e8384062f4341f8320a1a9c427d..2eaa34d7bb339dbb30e5bf526aa5fc4a5aa41aa9 100644
--- a/Source/core/inspector/PageDebuggerAgent.cpp
+++ b/Source/core/inspector/PageDebuggerAgent.cpp
@@ -33,9 +33,11 @@
 
 #include "bindings/v8/DOMWrapperWorld.h"
 #include "bindings/v8/PageScriptDebugServer.h"
+#include "bindings/v8/ScriptController.h"
 #include "core/inspector/InspectorOverlay.h"
 #include "core/inspector/InspectorPageAgent.h"
 #include "core/inspector/InstrumentingAgents.h"
+#include "core/page/Frame.h"
 #include "core/page/Page.h"
 #include "core/page/PageConsole.h"
 
@@ -136,7 +138,9 @@ void PageDebuggerAgent::didClearWindowObjectInWorld(Frame* frame, DOMWrapperWorl
         return;
 
     reset();
-    scriptDebugServer().setScriptPreprocessor(m_pageAgent->scriptPreprocessor());
+
+    if (!m_pageAgent->scriptPreprocessor().isEmpty())

[abarth-chromium, 2013/07/12 00:25:16]

Is this branch correct?  I would expect that if the pageAgent's
scriptPreprocessor became empty, we'd propagate that to the ScriptController at
this point.

[johnjbarton, 2013/07/12 17:56:49]

Yes test is correct: if the PageAgent has a scriptPreprocessor, load it in to
the controller.

In earlier versions we did pass the preprocessor source to the controller and we
used its empty status to clear the preprocessor object. You preferred at that
time to avoid this 'inline' signal. You also wanted the ScriptController to
exert direct control over the clear operation, and not delegate that
responsibility to PageDebuggerAgent. 

I added a comment to this code:
 // ScriptController::clearWindowShell() clears its ScriptPreprocessor before
didClearWindowObjectInWorld is dispatched.

+        frame->script()->setScriptPreprocessor(m_pageAgent->scriptPreprocessor());
 }
 
 } // namespace WebCore