Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 13573004: Enable CompositingIOSurfaceTransformerTest.* (Closed)

Created:
7 years, 8 months ago by miu
Modified:
7 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Enable CompositingIOSurfaceTransformerTest.* Due to weirdness with GPUs on trybots causing flakiness in tests, the initial implementation of CompositingIOSurfaceTransformer was committed with all unit tests disabled. This change will enable the tests, but force the software-based OpenGL implementation to be used. In a later change, we will allow the OpenGL implementation to auto-detect and utilize a GPU, where one is available. However, first the tests should prove themselves as stable when not using GPU. TBR=kbr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M content/browser/renderer_host/compositing_iosurface_transformer_mac_unittest.cc View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
miu
nick: PTAL, per our discussion a few weeks ago on introducing tests that invoke GPU ...
7 years, 8 months ago (2013-04-03 23:17:38 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
7 years, 8 months ago (2013-04-04 00:42:45 UTC) #2
ncarter (slow)
lgtm
7 years, 8 months ago (2013-04-04 21:22:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/13573004/1
7 years, 8 months ago (2013-04-04 22:37:33 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-04 22:45:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/13573004/1
7 years, 8 months ago (2013-04-04 22:57:05 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 03:52:47 UTC) #7
Message was sent while issue was closed.
Change committed as 192486

Powered by Google App Engine
This is Rietveld 408576698