Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 13572005: Fix crash when incognito split mode extension using the WebRequest API was reloaded (Closed)

Created:
7 years, 8 months ago by battre
Modified:
7 years, 8 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fix crash when incognito split mode extension using the WebRequest API was reloaded This fixes a CHECK assertion that was triggered if an incognito split mode extension with two background pages (each having an active web reqeust event listener) was restarted. The reason for the bug was that the event listener from the incognito background page would not be unregistered properly. BUG=224094 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -1 line) Patch
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/browser/extensions/event_router.cc View 1 chunk +5 lines, -1 line 0 comments Download
A chrome/test/data/extensions/api_test/webrequest_reload/background.js View 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webrequest_reload/manifest.json View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
battre
Hi Matt, please take a look at this CL. Thanks a lot, Dominic
7 years, 8 months ago (2013-04-04 09:37:23 UTC) #1
Matt Perry
LGTM, thanks for the quick fix!
7 years, 8 months ago (2013-04-04 19:16:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/13572005/1
7 years, 8 months ago (2013-04-04 21:51:25 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=6729
7 years, 8 months ago (2013-04-04 22:30:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/13572005/1
7 years, 8 months ago (2013-04-05 08:17:17 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=131386
7 years, 8 months ago (2013-04-05 09:46:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/13572005/1
7 years, 8 months ago (2013-04-05 09:49:45 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 09:55:56 UTC) #8
Message was sent while issue was closed.
Change committed as 192537

Powered by Google App Engine
This is Rietveld 408576698