Chromium Code Reviews Chromium Code Reviews
Issue
13564004:
Complete update of zlib from 1.2.3 to 1.2.5. (Closed)
DescriptionComplete update of zlib from 1.2.3 to 1.2.5.
You may think that https://codereview.chromium.org/8806004 , back in
2011, did this. However, that's not correct. That update only patched files which
were present in both our old, customized checkout and zlib 1.2.5.
In zlib 1.2.5, gzio.c was replaced with gzclose.c, gzguts.h, gzlib.c, gzread.c
and gzwrite.c. We did not add those files. We just used the gzio.c from 1.2.3
with our custom patches from Gears, together with the rest of 1.2.5.
This unholy chimera worked until I went ahead and tried to fix the broken
mangling for 64 bit API symbols. See
https://codereview.chromium.org/13473020/ . This uncovered the lack of
gzread64, which was, after that fix, referenced by libxml. Since gzio.c from
1.2.3 doesn't have gzread64, this was something of a problem. I'm thus
finishing the update.
R=agl@chromium.org,rsleevi@chromium.org,brettw@chromium.org,bradchen@chromium.org
BUG=None
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193127
Patch Set 1 #Patch Set 2 : try to fix windows build (tentative) #Patch Set 3 : narrow fix #Patch Set 4 : very narrow #Patch Set 5 : platform specific handling mostly done #Patch Set 6 : #elsif --> #elif #Patch Set 7 : fix diff #Patch Set 8 : actually fix patch #
Messages
Total messages: 15 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
