Added padding below text in notifications.

ui/message_center/cocoa/notification_controller.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/message_center/cocoa/notification_controller.h"
 
 #include "base/strings/sys_string_conversions.h"
 #include "grit/ui_resources.h"
 #include "skia/ext/skia_utils_mac.h"
 #import "third_party/GTM/AppKit/GTMUILocalizerAndLayoutTweaker.h"
 #import "ui/base/cocoa/hover_image_button.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/message_center/message_center_constants.h"
 #include "ui/message_center/notification.h"
 #include "ui/message_center/notification_change_observer.h"
 
+namespace {
+
+const int kTextTopPaddingAdjustment = -6;
+    // Compensates for padding already provided by UI elements involved.

[Robert Sesek, 2013/04/08 21:15:19]

Should go above the constant without any indentation.

[dharcourt, 2013/04/08 21:30:27]

Done.

+
+}  // namespace
 @interface MCNotificationController (Private)
 // Configures a NSBox to be borderless, titleless, and otherwise appearance-
 // free.
 - (void)configureCustomBox:(NSBox*)box;
 
 // Initializes the icon_ ivar and returns the view to insert into the hierarchy.
 - (NSView*)createImageView;
 
 // Initializes the closeButton_ ivar with the configured button.
 - (void)configureCloseButtonInFrame:(NSRect)rootFrame;
@@ skipping 45 matching lines @@
   // Create the title.
   [self configureTitleInFrame:rootFrame];
   [rootView addSubview:title_];
 
   // Create the message body.
   [self configureBodyInFrame:rootFrame maxY:NSMinY([title_ frame])];
   [rootView addSubview:message_];
 
   // In this basic notification UI, the message body is the bottom-most
   // vertical element. If it is out of the rootView's bounds, resize the view.
-  if (NSMinY([message_ frame]) < message_center::kTextTopPadding) {
-    rootFrame.size.height += message_center::kTextTopPadding -
-        NSMinY([message_ frame]);
+  if (NSMinY([message_ frame]) <
+      message_center::kTextTopPadding + kTextTopPaddingAdjustment) {

[Robert Sesek, 2013/04/08 21:15:19]

nit: indent 4 spaces since this is a continuation

[dharcourt, 2013/04/08 21:30:27]

Done.

+    rootFrame.size.height += message_center::kTextTopPadding +
+                             kTextTopPaddingAdjustment -
+                             NSMinY([message_ frame]);
   }
 
   [rootView setFrame:rootFrame];
 }
 
 - (void)close:(id)sender {
   observer_->OnRemoveNotification(notification_->id(), /*by_user=*/true);
 }
 
 - (const message_center::Notification*)notification {
@@ skipping 57 matching lines @@
   NSRect frame = [self currentContentRect];
 
   title_.reset([self newLabelWithFrame:NSMakeRect(0, 0, NSWidth(frame), 0)]);
   [title_ setAutoresizingMask:NSViewMinYMargin];
   [title_ setStringValue:base::SysUTF16ToNSString(notification_->title())];
   [title_ setFont:[NSFont messageFontOfSize:message_center::kTitleFontSize]];
 
   CGFloat delta =
       [GTMUILocalizerAndLayoutTweaker sizeToFitFixedWidthTextField:title_];
   frame.size.height = delta;
-  frame.origin.y = NSMaxY(rootFrame) - message_center::kTextTopPadding - delta;
+  frame.origin.y = NSMaxY(rootFrame) - message_center::kTextTopPadding +
+                   kTextTopPaddingAdjustment - delta;
   [title_ setFrame:frame];
 }
 
 - (void)configureBodyInFrame:(NSRect)rootFrame maxY:(CGFloat)maxY {
   NSRect frame = [self currentContentRect];
 
   message_.reset([self newLabelWithFrame:NSMakeRect(0, 0, NSWidth(frame), 0)]);
   [message_ setAutoresizingMask:NSViewMinYMargin];
   [message_ setStringValue:base::SysUTF16ToNSString(notification_->message())];
   [message_ setFont:
       [NSFont messageFontOfSize:message_center::kMessageFontSize]];
 
   CGFloat delta =
       [GTMUILocalizerAndLayoutTweaker sizeToFitFixedWidthTextField:message_];
   frame.size.height = delta;
-  frame.origin.y = maxY - message_center::kTextTopPadding - delta;
+  frame.origin.y = maxY - message_center::kTextTopPadding +
+                   kTextTopPaddingAdjustment - delta;
   [message_ setFrame:frame];
 }
 
 - (NSTextField*)newLabelWithFrame:(NSRect)frame {
   NSTextField* label = [[NSTextField alloc] initWithFrame:frame];
   [label setDrawsBackground:NO];
   [label setBezeled:NO];
   [label setEditable:NO];
   [label setSelectable:NO];
   [label setTextColor:gfx::SkColorToCalibratedNSColor(
       message_center::kRegularTextColor)];
   return label;
 }
 
 - (NSRect)currentContentRect {
   DCHECK(icon_);
   DCHECK(closeButton_);
 
   NSRect iconFrame, contentFrame;
   NSDivideRect([[self view] bounds], &iconFrame, &contentFrame,
       NSWidth([icon_ frame]) + message_center::kIconToTextPadding,
       NSMinXEdge);
   contentFrame.size.width -= NSWidth([closeButton_ frame]);
   return contentFrame;
 }
 
 @end