impl/prod/doc.go - Issue 1355783002: Refactor keys and queries in datastore service and implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/prod/doc.go

Issue 1355783002: Refactor keys and queries in datastore service and implementation. (Closed) Base URL: https://github.com/luci/gae.git@master

Patch Set: fix comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: impl/prod/doc.go

diff --git a/impl/prod/doc.go b/impl/prod/doc.go

index a913f6bf656d1f8073799a36dec2b4f2866e0532..7eaab23bfb352bd32752d6de041412fce2688fd6 100644

--- a/impl/prod/doc.go

+++ b/impl/prod/doc.go

@@ -5,3 +5,9 @@

// Package prod provides an implementation of infra/gae/libs/wrapper which

// backs to appengine.

package prod

+// BUG(fyi): *datastore.Key objects have their AppID dropped when this package

+// converts them internally to use with the underlying datastore. In

+// practice this shouldn't be much of an issue, since you normally

+// have no control over the AppID field of a Key anyway (aside from

+// deserializing one directly from a proto).