Issue 13556004: Add CreateWithDisableAero, to allow Windows capturer to be created without disabling Aero.

Issue 13556004: Add CreateWithDisableAero, to allow Windows capturer to be created without disabling Aero. (Closed)

Created:
7 years, 8 months ago by Wez

Modified:
7 years, 8 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add CreateWithDisableAero, to allow Windows capturer to be created without disabling Aero. BUG=195849 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194753

Patch Set 2 : Create screen capture device without disabling Aero. #

Total comments: 2

Patch Set 3 : Remove comment. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -16 lines)			Patch
M	media/video/capture/screen/screen_capture_device.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	media/video/capture/screen/screen_capturer.h	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	media/video/capture/screen/screen_capturer_win.cc	View		4 chunks	+22 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

lgtm https://codereview.chromium.org/13556004/diff/3001/media/video/capture/screen/screen_capturer.h File media/video/capture/screen/screen_capturer.h (right): https://codereview.chromium.org/13556004/diff/3001/media/video/capture/screen/screen_capturer.h#newcode93 media/video/capture/screen/screen_capturer.h:93: #endif // defined(OS_LINUX) update the comment. It might ...

7 years, 8 months ago (2013-04-10 03:20:26 UTC) #2

Wez

https://codereview.chromium.org/13556004/diff/3001/media/video/capture/screen/screen_capturer.h File media/video/capture/screen/screen_capturer.h (right): https://codereview.chromium.org/13556004/diff/3001/media/video/capture/screen/screen_capturer.h#newcode93 media/video/capture/screen/screen_capturer.h:93: #endif // defined(OS_LINUX) On 2013/04/10 03:20:26, sergeyu wrote: > ...

7 years, 8 months ago (2013-04-15 19:37:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/13556004/9001

7 years, 8 months ago (2013-04-17 23:23:52 UTC) #4

Message was sent while issue was closed.

Change committed as 194753

Expand Messages | Collapse Messages