Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 13555004: Aura: Make compositor_unittests work with --ui-enable-threaded-compositing (Closed)

Created:
7 years, 8 months ago by jonathan.backer
Modified:
7 years, 8 months ago
Reviewers:
sky, piman
CC:
chromium-reviews, sadrul, jonathan.backer, Ian Vollick, ben+watch_chromium.org, sail+watch_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Aura: Make compositor_unittests work with --ui-enable-threaded-compositing Check that a draw occured, rather than just that it was scheduled. Verify that CompositorDelegate is not called if compositing is threaded. BUG=173417 TEST=compositor_unittests --ui-enable-threaded-compositing Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192661

Patch Set 1 : "" #

Patch Set 2 : Set the delegates. DCHECK not called if threaded. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -53 lines) Patch
M ui/aura/root_window.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/compositor.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 1 29 chunks +56 lines, -53 lines 0 comments Download
M ui/compositor/test/test_compositor_host_linux.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/test/test_compositor_host_mac.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/test/test_compositor_host_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jonathan.backer
7 years, 8 months ago (2013-04-04 15:49:02 UTC) #1
jonathan.backer
Updated as per off-line discussion. PTAL.
7 years, 8 months ago (2013-04-05 13:25:38 UTC) #2
piman
lgtm
7 years, 8 months ago (2013-04-05 16:39:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/13555004/21002
7 years, 8 months ago (2013-04-05 18:58:04 UTC) #4
commit-bot: I haz the power
Presubmit check for 13555004-21002 failed and returned exit status 1. INFO:root:Found 7 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-05 18:58:10 UTC) #5
jonathan.backer
+sky for ui/aura/root_window.cc OWNERS
7 years, 8 months ago (2013-04-05 19:05:02 UTC) #6
sky
LGTM
7 years, 8 months ago (2013-04-05 19:45:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/13555004/21002
7 years, 8 months ago (2013-04-05 19:56:19 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-06 00:11:30 UTC) #9
Message was sent while issue was closed.
Change committed as 192661

Powered by Google App Engine
This is Rietveld 408576698