Issue 13552003: Add extra flag for load-ic stubs in code cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13552003: Add extra flag for load-ic stubs in code cache. (Closed)

Created:
7 years, 8 months ago by ulan

Modified:
7 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Add extra flag for load-ic stubs in code cache. This allows to distinguish between stubs compiled for the current object from stubs compiled for objects that have the current object as a prototype. BUG=v8:2593 R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14132

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -30 lines)			Patch
M	src/objects.h	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	src/stub-cache.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/stub-cache.cc	View	11 chunks	+16 lines, -12 lines	0 comments	Download
A +	test/mjsunit/regress/regress-2593.js	View	1 chunk	+27 lines, -16 lines	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

Other than a weird variable name in the test case, lgtm. Nice catch.

7 years, 8 months ago (2013-04-03 19:32:16 UTC) #2

ulan

7 years, 8 months ago (2013-04-04 08:29:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14132 (presubmit successful).