Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 13549002: [Android] "Namespace" shared libraries for the component build (Closed)

Created:
7 years, 8 months ago by Yaron
Modified:
7 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android] "Namespace" shared libraries for the component build With the component build, we tell Dalvik to load each library separately by name. Some of our library names conflict with android shared libraries resulting our library not getting loaded. When building for components on Android, change the suffix of libraries to "cr.so" e.g. libnetcr.so to avoid colliding with Android's copies BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192258

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : nit #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M android_webview/android_webview_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 2 3 1 chunk +14 lines, -1 line 0 comments Download
M build/java_apk.gypi View 1 2 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/chrome_android.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Yaron
7 years, 8 months ago (2013-04-03 22:30:20 UTC) #1
cjhopman
lgtm https://codereview.chromium.org/13549002/diff/4001/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/13549002/diff/4001/build/java_apk.gypi#newcode41 build/java_apk.gypi:41: # native_lib_target - The path to the target ...
7 years, 8 months ago (2013-04-03 22:47:06 UTC) #2
Yaron
joth: aw cries: content thakis: chrome
7 years, 8 months ago (2013-04-03 23:15:00 UTC) #3
Yaron
+thakis for real
7 years, 8 months ago (2013-04-03 23:15:18 UTC) #4
joth
lgtm
7 years, 8 months ago (2013-04-03 23:21:23 UTC) #5
Charlie Reis
content LGTM
7 years, 8 months ago (2013-04-03 23:38:19 UTC) #6
Nico
lgtm
7 years, 8 months ago (2013-04-03 23:53:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/13549002/15001
7 years, 8 months ago (2013-04-04 00:55:02 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-04 09:16:02 UTC) #9
Message was sent while issue was closed.
Change committed as 192258

Powered by Google App Engine
This is Rietveld 408576698