Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1785)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java

Issue 1354763003: [Contextual Search] Trigger the translation one-box. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated comment about test infrastructure needing to be updated when shifting to new API. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
index 0c07e65fece926884a35deedfdf378da95c4f988..210cf452ad47daa53c7c24286f5c850dd7fec96c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
@@ -9,6 +9,7 @@ import android.text.TextUtils;
import org.chromium.base.CommandLine;
import org.chromium.base.SysUtils;
+import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.ChromeVersionInfo;
import org.chromium.components.variations.VariationsAssociatedData;
@@ -36,6 +37,11 @@ public class ContextualSearchFieldTrial {
static final String DISABLE_EXTRA_SEARCH_BAR_ANIMATIONS = "disable_extra_search_bar_animations";
+ // Translation.
+ @VisibleForTesting
+ static final String TRANSLATION_ONEBOX_ENABLED = "translation_onebox_enabled";
+
+ // Tap handling.
private static final int UNLIMITED_TAPS = -1;
private static final int DEFAULT_TAP_RESOLVE_LIMIT_FOR_DECIDED = UNLIMITED_TAPS;
private static final int DEFAULT_TAP_PREFETCH_LIMIT_FOR_DECIDED = UNLIMITED_TAPS;
@@ -46,6 +52,7 @@ public class ContextualSearchFieldTrial {
private static Boolean sEnabled;
private static Boolean sIsPeekPromoEnabled;
private static Integer sPeekPromoMaxCount;
+ private static Boolean sIsTranslationOneboxEnabled;
/**
* Don't instantiate.
@@ -214,6 +221,16 @@ public class ContextualSearchFieldTrial {
return sPeekPromoMaxCount.intValue();
}
+ /**
+ * @return Whether triggering a translation Onebox in the SERP is enabled.
+ */
+ static boolean isTranslationOneboxEnabled() {
+ if (sIsTranslationOneboxEnabled == null) {
+ sIsTranslationOneboxEnabled = getBooleanParam(TRANSLATION_ONEBOX_ENABLED);
+ }
+ return sIsTranslationOneboxEnabled.booleanValue();
+ }
+
// --------------------------------------------------------------------------------------------
// Helpers.
// --------------------------------------------------------------------------------------------
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698