Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: chrome/browser/android/contextualsearch/contextual_search_delegate_unittest.cc

Issue 1354763003: [Contextual Search] Trigger the translation one-box. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated comment about test infrastructure needing to be updated when shifting to new API. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/contextualsearch/contextual_search_delegate.h" 5 #include "chrome/browser/android/contextualsearch/contextual_search_delegate.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/values.h" 10 #include "base/values.h"
11 #include "chrome/browser/android/contextualsearch/contextual_search_context.h" 11 #include "chrome/browser/android/contextualsearch/contextual_search_context.h"
12 #include "chrome/browser/android/contextualsearch/resolved_search_term.h"
12 #include "components/search_engines/template_url_service.h" 13 #include "components/search_engines/template_url_service.h"
13 #include "net/base/escape.h" 14 #include "net/base/escape.h"
14 #include "net/url_request/test_url_fetcher_factory.h" 15 #include "net/url_request/test_url_fetcher_factory.h"
15 #include "net/url_request/url_request_test_util.h" 16 #include "net/url_request/url_request_test_util.h"
16 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
17 18
18 using base::ListValue; 19 using base::ListValue;
19 20
20 namespace { 21 namespace {
21 22
(...skipping 21 matching lines...) Expand all
43 base::Bind(&ContextualSearchDelegateTest::recordIcingSelectionAvailable, 44 base::Bind(&ContextualSearchDelegateTest::recordIcingSelectionAvailable,
44 base::Unretained(this)))); 45 base::Unretained(this))));
45 } 46 }
46 47
47 void TearDown() override { 48 void TearDown() override {
48 fetcher_ = NULL; 49 fetcher_ = NULL;
49 is_invalid_ = true; 50 is_invalid_ = true;
50 response_code_ = -1; 51 response_code_ = -1;
51 search_term_ = "invalid"; 52 search_term_ = "invalid";
52 display_text_ = "unknown"; 53 display_text_ = "unknown";
54 context_language_ = "";
53 } 55 }
54 56
55 TemplateURLService* CreateTemplateURLService() { 57 TemplateURLService* CreateTemplateURLService() {
56 // Set a default search provider that supports Contextual Search. 58 // Set a default search provider that supports Contextual Search.
57 TemplateURLData data; 59 TemplateURLData data;
58 data.SetURL("https://foobar.com/url?bar={searchTerms}"); 60 data.SetURL("https://foobar.com/url?bar={searchTerms}");
59 data.contextual_search_url = "https://foobar.com/_/contextualsearch?" 61 data.contextual_search_url = "https://foobar.com/_/contextualsearch?"
60 "{google:contextualSearchVersion}{google:contextualSearchContextData}"; 62 "{google:contextualSearchVersion}{google:contextualSearchContextData}";
61 TemplateURL* template_url = new TemplateURL(data); 63 TemplateURL* template_url = new TemplateURL(data);
62 // Takes ownership of |template_url|. 64 // Takes ownership of |template_url|.
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 net::TestURLFetcher* fetcher() { return fetcher_; } 132 net::TestURLFetcher* fetcher() { return fetcher_; }
131 bool is_invalid() { return is_invalid_; } 133 bool is_invalid() { return is_invalid_; }
132 int response_code() { return response_code_; } 134 int response_code() { return response_code_; }
133 std::string search_term() { return search_term_; } 135 std::string search_term() { return search_term_; }
134 std::string display_text() { return display_text_; } 136 std::string display_text() { return display_text_; }
135 std::string alternate_term() { return alternate_term_; } 137 std::string alternate_term() { return alternate_term_; }
136 bool do_prevent_preload() { return prevent_preload_; } 138 bool do_prevent_preload() { return prevent_preload_; }
137 std::string after_text() { return after_text_; } 139 std::string after_text() { return after_text_; }
138 int start_adjust() { return start_adjust_; } 140 int start_adjust() { return start_adjust_; }
139 int end_adjust() { return end_adjust_; } 141 int end_adjust() { return end_adjust_; }
142 std::string context_language() { return context_language_; }
140 143
141 // The delegate under test. 144 // The delegate under test.
142 scoped_ptr<ContextualSearchDelegate> delegate_; 145 scoped_ptr<ContextualSearchDelegate> delegate_;
143 146
144 private: 147 private:
145 void recordSearchTermResolutionResponse(bool is_invalid, 148 void recordSearchTermResolutionResponse(
146 int response_code, 149 const ResolvedSearchTerm& resolved_search_term) {
147 const std::string& search_term, 150 is_invalid_ = resolved_search_term.is_invalid;
148 const std::string& display_text, 151 response_code_ = resolved_search_term.response_code;
149 const std::string& alternate_term, 152 search_term_ = resolved_search_term.search_term;
150 bool prevent_preload, 153 display_text_ = resolved_search_term.display_text;
151 int start_adjust, 154 alternate_term_ = resolved_search_term.alternate_term;
152 int end_adjust) { 155 prevent_preload_ = resolved_search_term.prevent_preload;
153 is_invalid_ = is_invalid; 156 start_adjust_ = resolved_search_term.selection_start_adjust;
154 response_code_ = response_code; 157 end_adjust_ = resolved_search_term.selection_end_adjust;
155 search_term_ = search_term; 158 context_language_ = resolved_search_term.context_language;
156 display_text_ = display_text;
157 alternate_term_ = alternate_term;
158 prevent_preload_ = prevent_preload;
159 start_adjust_ = start_adjust;
160 end_adjust_ = end_adjust;
161 } 159 }
162 160
163 void recordSurroundingText(const std::string& after_text) { 161 void recordSurroundingText(const std::string& after_text) {
164 after_text_ = after_text; 162 after_text_ = after_text;
165 } 163 }
166 164
167 void recordIcingSelectionAvailable(const std::string& encoding, 165 void recordIcingSelectionAvailable(const std::string& encoding,
168 const base::string16& surrounding_text, 166 const base::string16& surrounding_text,
169 size_t start_offset, 167 size_t start_offset,
170 size_t end_offset) { 168 size_t end_offset) {
171 // unused. 169 // unused.
172 } 170 }
173 171
174 bool is_invalid_; 172 bool is_invalid_;
175 int response_code_; 173 int response_code_;
176 std::string search_term_; 174 std::string search_term_;
177 std::string display_text_; 175 std::string display_text_;
178 std::string alternate_term_; 176 std::string alternate_term_;
179 bool prevent_preload_; 177 bool prevent_preload_;
180 int start_adjust_; 178 int start_adjust_;
181 int end_adjust_; 179 int end_adjust_;
182 std::string after_text_; 180 std::string after_text_;
181 std::string context_language_;
183 182
184 base::MessageLoopForIO io_message_loop_; 183 base::MessageLoopForIO io_message_loop_;
185 net::TestURLFetcherFactory test_factory_; 184 net::TestURLFetcherFactory test_factory_;
186 net::TestURLFetcher* fetcher_; 185 net::TestURLFetcher* fetcher_;
187 scoped_ptr<TemplateURLService> template_url_service_; 186 scoped_ptr<TemplateURLService> template_url_service_;
188 scoped_refptr<net::TestURLRequestContextGetter> request_context_; 187 scoped_refptr<net::TestURLRequestContextGetter> request_context_;
189 188
190 // Will be owned by the delegate. 189 // Will be owned by the delegate.
191 ContextualSearchContext* test_context_; 190 ContextualSearchContext* test_context_;
192 191
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 int limit_each_side = -2; 444 int limit_each_side = -2;
446 size_t start = 8; 445 size_t start = 8;
447 size_t end = 20; 446 size_t end = 20;
448 base::string16 result = 447 base::string16 result =
449 delegate_->SurroundingTextForIcing(sample, limit_each_side, &start, &end); 448 delegate_->SurroundingTextForIcing(sample, limit_each_side, &start, &end);
450 EXPECT_EQ(static_cast<size_t>(0), start); 449 EXPECT_EQ(static_cast<size_t>(0), start);
451 EXPECT_EQ(static_cast<size_t>(12), end); 450 EXPECT_EQ(static_cast<size_t>(12), end);
452 EXPECT_EQ(base::ASCIIToUTF16("Barack Obama"), result); 451 EXPECT_EQ(base::ASCIIToUTF16("Barack Obama"), result);
453 } 452 }
454 453
455 TEST_F(ContextualSearchDelegateTest, DecodeSearchTermsFromJsonResponse) { 454 TEST_F(ContextualSearchDelegateTest, DecodeSearchTermFromJsonResponse) {
456 std::string json_with_escape = 455 std::string json_with_escape =
457 ")]}'\n" 456 ")]}'\n"
458 "{\"mid\":\"/m/02mjmr\", \"search_term\":\"obama\"," 457 "{\"mid\":\"/m/02mjmr\", \"search_term\":\"obama\","
459 "\"info_text\":\"44th U.S. President\"," 458 "\"info_text\":\"44th U.S. President\","
460 "\"display_text\":\"Barack Obama\", \"mentions\":[0,15]," 459 "\"display_text\":\"Barack Obama\", \"mentions\":[0,15],"
461 "\"selected_text\":\"obama\", \"resolved_term\":\"barack obama\"}"; 460 "\"selected_text\":\"obama\", \"resolved_term\":\"barack obama\"}";
462 std::string search_term; 461 std::string search_term;
463 std::string display_text; 462 std::string display_text;
464 std::string alternate_term; 463 std::string alternate_term;
465 std::string prevent_preload; 464 std::string prevent_preload;
466 int mention_start; 465 int mention_start;
467 int mention_end; 466 int mention_end;
468 delegate_->DecodeSearchTermsFromJsonResponse(json_with_escape, &search_term, 467 std::string context_language;
469 &display_text, &alternate_term, 468 delegate_->DecodeSearchTermFromJsonResponse(
470 &prevent_preload, &mention_start, 469 json_with_escape, &search_term, &display_text, &alternate_term,
471 &mention_end); 470 &prevent_preload, &mention_start, &mention_end, &context_language);
472 EXPECT_EQ("obama", search_term); 471 EXPECT_EQ("obama", search_term);
473 EXPECT_EQ("Barack Obama", display_text); 472 EXPECT_EQ("Barack Obama", display_text);
474 EXPECT_EQ("barack obama", alternate_term); 473 EXPECT_EQ("barack obama", alternate_term);
475 EXPECT_EQ("", prevent_preload); 474 EXPECT_EQ("", prevent_preload);
475 EXPECT_EQ("", context_language);
476 } 476 }
477
478 TEST_F(ContextualSearchDelegateTest, ResponseWithLanguage) {
479 CreateDefaultSearchContextAndRequestSearchTerm();
480 fetcher()->set_response_code(200);
481 fetcher()->SetResponseString(
482 "{\"mid\":\"/m/02mjmr\",\"search_term\":\"obama\","
483 "\"mentions\":[0,15],\"prevent_preload\":\"1\", "
484 "\"lang\":\"de\"}");
485 fetcher()->delegate()->OnURLFetchComplete(fetcher());
486
487 EXPECT_FALSE(is_invalid());
488 EXPECT_EQ(200, response_code());
489 EXPECT_EQ("obama", search_term());
490 EXPECT_EQ("obama", display_text());
491 EXPECT_TRUE(do_prevent_preload());
492 EXPECT_TRUE(DoesRequestContainOurSpecificBasePage());
493 EXPECT_EQ("de", context_language());
494 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698