Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: chrome/browser/android/contextualsearch/contextual_search_delegate_unittest.cc

Issue 1354763003: [Contextual Search] Trigger the translation one-box. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable for non-English users, for now. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/contextualsearch/contextual_search_delegate.h" 5 #include "chrome/browser/android/contextualsearch/contextual_search_delegate.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/values.h" 10 #include "base/values.h"
11 #include "chrome/browser/android/contextualsearch/contextual_search_context.h" 11 #include "chrome/browser/android/contextualsearch/contextual_search_context.h"
12 #include "chrome/browser/android/contextualsearch/resolved_search_term.h"
12 #include "components/search_engines/template_url_service.h" 13 #include "components/search_engines/template_url_service.h"
13 #include "net/url_request/test_url_fetcher_factory.h" 14 #include "net/url_request/test_url_fetcher_factory.h"
14 #include "net/url_request/url_request_test_util.h" 15 #include "net/url_request/url_request_test_util.h"
15 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
16 17
17 using base::ListValue; 18 using base::ListValue;
18 19
19 namespace { 20 namespace {
20 21
21 const char kSomeSpecificBasePage[] = "http://some.specific.host.name.com"; 22 const char kSomeSpecificBasePage[] = "http://some.specific.host.name.com";
(...skipping 20 matching lines...) Expand all
42 base::Bind(&ContextualSearchDelegateTest::recordIcingSelectionAvailable, 43 base::Bind(&ContextualSearchDelegateTest::recordIcingSelectionAvailable,
43 base::Unretained(this)))); 44 base::Unretained(this))));
44 } 45 }
45 46
46 void TearDown() override { 47 void TearDown() override {
47 fetcher_ = NULL; 48 fetcher_ = NULL;
48 is_invalid_ = true; 49 is_invalid_ = true;
49 response_code_ = -1; 50 response_code_ = -1;
50 search_term_ = "invalid"; 51 search_term_ = "invalid";
51 display_text_ = "unknown"; 52 display_text_ = "unknown";
53 context_language_ = "";
52 } 54 }
53 55
54 TemplateURLService* CreateTemplateURLService() { 56 TemplateURLService* CreateTemplateURLService() {
55 // Set a default search provider that supports Contextual Search. 57 // Set a default search provider that supports Contextual Search.
56 TemplateURLData data; 58 TemplateURLData data;
57 data.SetURL("https://foobar.com/url?bar={searchTerms}"); 59 data.SetURL("https://foobar.com/url?bar={searchTerms}");
58 data.contextual_search_url = "https://foobar.com/_/contextualsearch?" 60 data.contextual_search_url = "https://foobar.com/_/contextualsearch?"
59 "{google:contextualSearchVersion}{google:contextualSearchContextData}"; 61 "{google:contextualSearchVersion}{google:contextualSearchContextData}";
60 TemplateURL* template_url = new TemplateURL(data); 62 TemplateURL* template_url = new TemplateURL(data);
61 // Takes ownership of |template_url|. 63 // Takes ownership of |template_url|.
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 net::TestURLFetcher* fetcher() { return fetcher_; } 131 net::TestURLFetcher* fetcher() { return fetcher_; }
130 bool is_invalid() { return is_invalid_; } 132 bool is_invalid() { return is_invalid_; }
131 int response_code() { return response_code_; } 133 int response_code() { return response_code_; }
132 std::string search_term() { return search_term_; } 134 std::string search_term() { return search_term_; }
133 std::string display_text() { return display_text_; } 135 std::string display_text() { return display_text_; }
134 std::string alternate_term() { return alternate_term_; } 136 std::string alternate_term() { return alternate_term_; }
135 bool do_prevent_preload() { return prevent_preload_; } 137 bool do_prevent_preload() { return prevent_preload_; }
136 std::string after_text() { return after_text_; } 138 std::string after_text() { return after_text_; }
137 int start_adjust() { return start_adjust_; } 139 int start_adjust() { return start_adjust_; }
138 int end_adjust() { return end_adjust_; } 140 int end_adjust() { return end_adjust_; }
141 std::string context_language() { return context_language_; }
139 142
140 // The delegate under test. 143 // The delegate under test.
141 scoped_ptr<ContextualSearchDelegate> delegate_; 144 scoped_ptr<ContextualSearchDelegate> delegate_;
142 145
143 private: 146 private:
144 void recordSearchTermResolutionResponse(bool is_invalid, 147 void recordSearchTermResolutionResponse(
145 int response_code, 148 const ResolvedSearchTerm& resolved_search_term) {
146 const std::string& search_term, 149 is_invalid_ = resolved_search_term.is_invalid;
147 const std::string& display_text, 150 response_code_ = resolved_search_term.response_code;
148 const std::string& alternate_term, 151 search_term_ = resolved_search_term.search_term;
149 bool prevent_preload, 152 display_text_ = resolved_search_term.display_text;
150 int start_adjust, 153 alternate_term_ = resolved_search_term.alternate_term;
151 int end_adjust) { 154 prevent_preload_ = resolved_search_term.prevent_preload;
152 is_invalid_ = is_invalid; 155 start_adjust_ = resolved_search_term.selection_start_adjust;
153 response_code_ = response_code; 156 end_adjust_ = resolved_search_term.selection_end_adjust;
154 search_term_ = search_term; 157 context_language_ = resolved_search_term.context_language;
155 display_text_ = display_text;
156 alternate_term_ = alternate_term;
157 prevent_preload_ = prevent_preload;
158 start_adjust_ = start_adjust;
159 end_adjust_ = end_adjust;
160 } 158 }
161 159
162 void recordSurroundingText(const std::string& after_text) { 160 void recordSurroundingText(const std::string& after_text) {
163 after_text_ = after_text; 161 after_text_ = after_text;
164 } 162 }
165 163
166 void recordIcingSelectionAvailable(const std::string& encoding, 164 void recordIcingSelectionAvailable(const std::string& encoding,
167 const base::string16& surrounding_text, 165 const base::string16& surrounding_text,
168 size_t start_offset, 166 size_t start_offset,
169 size_t end_offset) { 167 size_t end_offset) {
170 // unused. 168 // unused.
171 } 169 }
172 170
173 bool is_invalid_; 171 bool is_invalid_;
174 int response_code_; 172 int response_code_;
175 std::string search_term_; 173 std::string search_term_;
176 std::string display_text_; 174 std::string display_text_;
177 std::string alternate_term_; 175 std::string alternate_term_;
178 bool prevent_preload_; 176 bool prevent_preload_;
179 int start_adjust_; 177 int start_adjust_;
180 int end_adjust_; 178 int end_adjust_;
181 std::string after_text_; 179 std::string after_text_;
180 std::string context_language_;
182 181
183 base::MessageLoopForIO io_message_loop_; 182 base::MessageLoopForIO io_message_loop_;
184 net::TestURLFetcherFactory test_factory_; 183 net::TestURLFetcherFactory test_factory_;
185 net::TestURLFetcher* fetcher_; 184 net::TestURLFetcher* fetcher_;
186 scoped_ptr<TemplateURLService> template_url_service_; 185 scoped_ptr<TemplateURLService> template_url_service_;
187 scoped_refptr<net::TestURLRequestContextGetter> request_context_; 186 scoped_refptr<net::TestURLRequestContextGetter> request_context_;
188 187
189 // Will be owned by the delegate. 188 // Will be owned by the delegate.
190 ContextualSearchContext* test_context_; 189 ContextualSearchContext* test_context_;
191 190
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 int limit_each_side = -2; 443 int limit_each_side = -2;
445 size_t start = 8; 444 size_t start = 8;
446 size_t end = 20; 445 size_t end = 20;
447 base::string16 result = 446 base::string16 result =
448 delegate_->SurroundingTextForIcing(sample, limit_each_side, &start, &end); 447 delegate_->SurroundingTextForIcing(sample, limit_each_side, &start, &end);
449 EXPECT_EQ(static_cast<size_t>(0), start); 448 EXPECT_EQ(static_cast<size_t>(0), start);
450 EXPECT_EQ(static_cast<size_t>(12), end); 449 EXPECT_EQ(static_cast<size_t>(12), end);
451 EXPECT_EQ(base::ASCIIToUTF16("Barack Obama"), result); 450 EXPECT_EQ(base::ASCIIToUTF16("Barack Obama"), result);
452 } 451 }
453 452
454 TEST_F(ContextualSearchDelegateTest, DecodeSearchTermsFromJsonResponse) { 453 TEST_F(ContextualSearchDelegateTest, DecodeSearchTermFromJsonResponse) {
455 std::string json_with_escape = 454 std::string json_with_escape =
456 ")]}'\n" 455 ")]}'\n"
457 "{\"mid\":\"/m/02mjmr\", \"search_term\":\"obama\"," 456 "{\"mid\":\"/m/02mjmr\", \"search_term\":\"obama\","
458 "\"info_text\":\"44th U.S. President\"," 457 "\"info_text\":\"44th U.S. President\","
459 "\"display_text\":\"Barack Obama\", \"mentions\":[0,15]," 458 "\"display_text\":\"Barack Obama\", \"mentions\":[0,15],"
460 "\"selected_text\":\"obama\", \"resolved_term\":\"barack obama\"}"; 459 "\"selected_text\":\"obama\", \"resolved_term\":\"barack obama\"}";
461 std::string search_term; 460 std::string search_term;
462 std::string display_text; 461 std::string display_text;
463 std::string alternate_term; 462 std::string alternate_term;
464 std::string prevent_preload; 463 std::string prevent_preload;
465 int mention_start; 464 int mention_start;
466 int mention_end; 465 int mention_end;
467 delegate_->DecodeSearchTermsFromJsonResponse(json_with_escape, &search_term, 466 std::string context_language;
468 &display_text, &alternate_term, 467 delegate_->DecodeSearchTermFromJsonResponse(
469 &prevent_preload, &mention_start, 468 json_with_escape, &search_term, &display_text, &alternate_term,
470 &mention_end); 469 &prevent_preload, &mention_start, &mention_end, &context_language);
471 EXPECT_EQ("obama", search_term); 470 EXPECT_EQ("obama", search_term);
472 EXPECT_EQ("Barack Obama", display_text); 471 EXPECT_EQ("Barack Obama", display_text);
473 EXPECT_EQ("barack obama", alternate_term); 472 EXPECT_EQ("barack obama", alternate_term);
474 EXPECT_EQ("", prevent_preload); 473 EXPECT_EQ("", prevent_preload);
474 EXPECT_EQ("", content_language);
475 } 475 }
476
477 TEST_F(ContextualSearchDelegateTest, ResponseWithLanguage) {
478 CreateDefaultSearchContextAndRequestSearchTerm();
479 fetcher()->set_response_code(200);
480 fetcher()->SetResponseString(
481 "{\"mid\":\"/m/02mjmr\",\"search_term\":\"obama\","
482 "\"mentions\":[0,15],\"prevent_preload\":\"1\", "
483 "\"lang\":\"de\"}");
484 fetcher()->delegate()->OnURLFetchComplete(fetcher());
485
486 EXPECT_FALSE(is_invalid());
487 EXPECT_EQ(200, response_code());
488 EXPECT_EQ("obama", search_term());
489 EXPECT_EQ("obama", display_text());
490 EXPECT_TRUE(do_prevent_preload());
491 EXPECT_TRUE(DoesRequestContainOurSpecificBasePage());
492 EXPECT_EQ("de", contextLanguage());
493 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698