[Contextual Search] Trigger the translation one-box.

chrome/browser/android/contextualsearch/contextual_search_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_CONTEXTUALSEARCH_CONTEXTUAL_SEARCH_MANAGER_H_
 #define CHROME_BROWSER_ANDROID_CONTEXTUALSEARCH_CONTEXTUAL_SEARCH_MANAGER_H_
 
 #include "base/android/jni_android.h"
 #include "base/task/cancelable_task_tracker.h"
 #include "chrome/browser/android/contextualsearch/contextual_search_context.h"
@@ skipping 28 matching lines @@
 
   // Gathers the surrounding text around the selection and saves it locally.
   // Does not send a search term resolution request to the server.
   void GatherSurroundingText(JNIEnv* env,
                              jobject obj,
                              jstring j_selection,
                              jboolean j_use_resolved_search_term,
                              jobject j_base_content_view_core,
                              jboolean j_may_send_base_page_url);
 
+  // Gets the target language for translation purposes.
+  // TODO(donnd): Can we get rid of the jobject if it's not being used?

[pedro (no code reviews), 2015/09/23 18:33:55]

The jobj is being implicitly used when you pass the pointer from java, so you
need it in there.

[Donn Denman, 2015/10/09 22:08:23]

Acknowledged.

+  base::android::ScopedJavaLocalRef<jstring> GetTargetLanguage(JNIEnv* env,
+                                                               jobject obj);
+
  private:
-  // TODO(donnd): encapsulate these response parameters?
-  void OnSearchTermResolutionResponse(bool is_invalid,
-                                      int response_code,
-                                      const std::string& search_term,
-                                      const std::string& display_text,
-                                      const std::string& alternate_term,
-                                      bool prevent_preload,
-                                      int selection_start_adjust,
-                                      int selection_end_adjust);
+  void OnSearchTermResolutionResponse(
+      const ResolvedSearchTerm& resolved_search_term);
 
   // Calls back to Java with the surrounding text to be displayed.
   void OnSurroundingTextAvailable(const std::string& before_text,
                                   const std::string& after_text);
 
   // Calls back to Java with notification for Icing selection.
   void OnIcingSelectionAvailable(const std::string& encoding,
                                  const base::string16& surrounding_text,
                                  size_t start_offset,
                                  size_t end_offset);
 
   // Our global reference to the Java ContextualSearchManager.
   base::android::ScopedJavaGlobalRef<jobject> java_manager_;
 
   // The delegate we're using the do the real work.
   scoped_ptr<ContextualSearchDelegate> delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(ContextualSearchManager);
 };
 
 bool RegisterContextualSearchManager(JNIEnv* env);
 
 #endif  // CHROME_BROWSER_ANDROID_CONTEXTUALSEARCH_CONTEXTUAL_SEARCH_MANAGER_H_