Remove PlatformWidget references

Remove PlatformWidget references

Chromium doesn't use PlatformWidgets to back Widgets. This deletes the PlatformWidget
references from the code, platformWidget() branches from various view classes,
and logic associated with compositing different PlatformWidget-backed iframes separately.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147643

[jamesr, 2013-04-05 01:42:15]

diffstat:

 Source/WebCore/WebCore.gypi                                 |   1 -
 Source/WebCore/accessibility/AccessibilityScrollView.cpp    |   2 +-
 Source/WebCore/loader/FrameLoaderClient.h                   |   5 -----
 Source/WebCore/page/FocusController.cpp                     |   6 ++----
 Source/WebCore/page/FrameView.cpp                           |  71
+++--------------------------------------------------------------------
 Source/WebCore/page/FrameView.h                             |   2 --
 Source/WebCore/platform/ScrollView.cpp                      | 102
+++++-------------------------------------------------------------------------------------------------
 Source/WebCore/platform/ScrollView.h                        |  13 -------------
 Source/WebCore/platform/Widget.cpp                          |   5 +----
 Source/WebCore/platform/Widget.h                            | 114
+++---------------------------------------------------------------------------------------------------------------
 Source/WebCore/platform/chromium/PlatformScreenChromium.cpp |   1 +
 Source/WebCore/platform/chromium/PlatformWidget.h           |  42
------------------------------------------
 Source/WebCore/platform/chromium/WidgetChromium.cpp         |   4 ++--
 Source/WebCore/plugins/PluginView.h                         |  50
--------------------------------------------------
 Source/WebCore/plugins/PluginViewBase.h                     |   2 +-
 Source/WebCore/rendering/RenderLayerCompositor.cpp          |  44
++------------------------------------------
 Source/WebCore/rendering/RenderLayerCompositor.h            |   3 ---
 Source/WebCore/rendering/RenderTreeAsText.cpp               |  17
-----------------
 Source/WebCore/rendering/RenderWidget.cpp                   |   2 +-
 Source/WebKit/chromium/src/WebPluginContainerImpl.cpp       |   2 +-
 20 files changed, 23 insertions(+), 465 deletions(-)

[eseidel, 2013-04-05 01:55:59]

FYI, I'm meeting with Fady and W. James tomorrow about removing with Widget tree
entirely.  If you'd like to come to the VC party, I'm happy to send you an
invite. :)

[eseidel, 2013-04-05 01:59:24]

CCing Mr. AX just in case.

https://codereview.chromium.org/13544008/diff/1/Source/WebCore/accessibility/...
File Source/WebCore/accessibility/AccessibilityScrollView.cpp (left):

https://codereview.chromium.org/13544008/diff/1/Source/WebCore/accessibility/...
Source/WebCore/accessibility/AccessibilityScrollView.cpp:79: bool
AccessibilityScrollView::isAttachment() const
What is this even for?  I feel like we should grep for WebKit2 across the code
base... :)

[darin (slow to review), 2013-04-05 05:14:07]

LGTM

[jamesr, 2013-04-05 18:52:00]

Committed patchset #1 manually as r147643 (presubmit successful).

[dmazzoni, 2013-04-05 23:01:14]

https://codereview.chromium.org/13544008/diff/1/Source/WebCore/accessibility/...
File Source/WebCore/accessibility/AccessibilityScrollView.cpp (left):

https://codereview.chromium.org/13544008/diff/1/Source/WebCore/accessibility/...
Source/WebCore/accessibility/AccessibilityScrollView.cpp:79: bool
AccessibilityScrollView::isAttachment() const
On 2013/04/05 01:59:24, Eric Seidel (Google) wrote:
> What is this even for?  I feel like we should grep for WebKit2 across the code
> base... :)

I don't really understand what this is for and I plan to remove it.