chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java - Issue 1354323003: Fix up _some_web app directory StrictMode violations

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Issue 1354323003: Fix up _some_web app directory StrictMode violations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments, rebasing Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/android/java/src/org/chromium/base/FileUtils.java ('K') | « base/android/java/src/org/chromium/base/FileUtils.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

index 1912b565e9877cc30608894e1893de9ebd040cd3..945a9645acdd4855e7534dbe4fc7006adff272eb 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

@@ -33,7 +33,6 @@ import org.chromium.chrome.browser.tab.EmptyTabObserver;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tab.TabObserver;

import org.chromium.chrome.browser.util.ColorUtils;

-import org.chromium.chrome.browser.util.FeatureUtilities;

import org.chromium.content.browser.ScreenOrientationProvider;

import org.chromium.content_public.browser.LoadUrlParams;

import org.chromium.content_public.browser.WebContentsObserver;

@@ -52,7 +51,7 @@ public class WebappActivity extends FullScreenActivity {

private static final long MS_BEFORE_NAVIGATING_BACK_FROM_INTERSTITIAL = 1000;

private final WebappInfo mWebappInfo;

- private AsyncTask<Void, Void, Void> mCleanupTask;

+ private AsyncTask<WebappActivity, Void, Void> mCleanupTask;

private WebContentsObserver mWebContentsObserver;

@@ -109,8 +108,7 @@ public class WebappActivity extends FullScreenActivity {

WebappInfo info = WebappInfo.create(getIntent());

if (info != null) mWebappInfo.copy(info);

- mCleanupTask = new WebappDirectoryManager(getActivityDirectory(),

- WEBAPP_SCHEME, FeatureUtilities.isDocumentModeEligible(this));

+ mCleanupTask = new WebappDirectoryManager();

ScreenOrientationProvider.lockOrientation((byte) mWebappInfo.orientation(), this);

super.preInflationStartup();

@@ -133,7 +131,7 @@ public class WebappActivity extends FullScreenActivity {

@Override

public void onStartWithNative() {

super.onStartWithNative();

- if (mCleanupTask.getStatus() == AsyncTask.Status.PENDING) mCleanupTask.execute();

+ if (mCleanupTask.getStatus() == AsyncTask.Status.PENDING) mCleanupTask.execute(this);

Peter Wen 2015/09/22 19:24:55 Since no other AsyncTasks depend on cleanup finish

Yaron 2015/09/22 20:28:08 +1

gone 2015/09/23 11:07:03 Done.

}

@Override