Issue 13541003: Reorder platforms in build_config to fix Android on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13541003: Reorder platforms in build_config to fix Android on Mac. (Closed)

Created:
7 years, 8 months ago by Torne

Modified:
7 years, 8 months ago

Reviewers:
benm (inactive)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reorder platforms in build_config to fix Android on Mac. The Android port relies on the global define ANDROID to identify that we are crosscompiling for Android, but __APPLE__ was being checked first in build_config.h, and so builds on a Mac sometimes ended up with the wrong OS_* macro defined. Reorder the list so that ANDROID is tested first, as it will only be set manually when crosscompiling (__APPLE__ is set internally by the compiler). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192303

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	build/build_config.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/13541003/1

7 years, 8 months ago (2013-04-04 09:42:46 UTC) #3

Message was sent while issue was closed.

Change committed as 192303

Expand Messages | Collapse Messages