Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 13537006: Add input md5 check to create_device_library_links.py (Closed)

Created:
7 years, 8 months ago by cjhopman
Modified:
7 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Add input md5 check to create_device_library_links.py The md5 stamp path includes the device serial (i.e. the stamp is library-device specific). Also, this no longer creates a shell for-loop as the command to send to adb. adb shell has a ~1000 character limit for commands, and the for-loop was exceeding that limit. Now that we only create links for libraries that actually have changed, there is not as much benefit to creating all the links in one adb command. BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192484

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M build/android/gyp/create_device_library_links.py View 4 chunks +26 lines, -16 lines 0 comments Download
M build/java_apk.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cjhopman
7 years, 8 months ago (2013-04-04 01:25:39 UTC) #1
Yaron
lgtm
7 years, 8 months ago (2013-04-04 20:36:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13537006/1
7 years, 8 months ago (2013-04-05 00:11:02 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 03:51:53 UTC) #4
Message was sent while issue was closed.
Change committed as 192484

Powered by Google App Engine
This is Rietveld 408576698