Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 13532013: add in deltaBaseCacheLimit workaround (Closed)

Created:
7 years, 8 months ago by Dirk Pranke
Modified:
7 years, 8 months ago
Reviewers:
iannucci, M-A Ruel
CC:
chromium-reviews, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, agable, iannucci, jamesr, cmp, sop
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

add in deltaBaseCacheLimit workaround R=maruel@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=192358

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M fetch.py View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Dirk Pranke
7 years, 8 months ago (2013-04-04 17:29:56 UTC) #1
M-A Ruel
lgtm
7 years, 8 months ago (2013-04-04 17:32:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/13532013/1
7 years, 8 months ago (2013-04-04 17:33:43 UTC) #3
commit-bot: I haz the power
Change committed as 192358
7 years, 8 months ago (2013-04-04 17:36:05 UTC) #4
iannucci
https://chromiumcodereview.appspot.com/13532013/diff/1/fetch.py File fetch.py (right): https://chromiumcodereview.appspot.com/13532013/diff/1/fetch.py#newcode114 fetch.py:114: self.run_git('config', '--global', 'core.deltaBaseCacheLimit', '1G') It would have been cooler ...
7 years, 8 months ago (2013-04-04 18:21:30 UTC) #5
Dirk Pranke
7 years, 8 months ago (2013-04-04 18:31:26 UTC) #6
Message was sent while issue was closed.
On 2013/04/04 18:21:30, iannucci wrote:
> https://chromiumcodereview.appspot.com/13532013/diff/1/fetch.py
> File fetch.py (right):
> 
> https://chromiumcodereview.appspot.com/13532013/diff/1/fetch.py#newcode114
> fetch.py:114: self.run_git('config', '--global', 'core.deltaBaseCacheLimit',
> '1G')
> It would have been cooler to init an empty git repo and set this locally. Some
> people (including me, of course :), have their global git config under version
> control. Not sure how temporary this will be to say if there should be any
> effort to fix this at all though.

Yeah, I vaguely thought about that, and decided it wouldn't mesh very well with
the recipes. I'm hoping this'll be a temporary thing.

Powered by Google App Engine
This is Rietveld 408576698