Stop inserting placeholders for TextArea and Input elements.

Source/WebCore/editing/DeleteSelectionCommand.cpp

 /*
  * Copyright (C) 2005 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 19 matching lines @@
 #include "DocumentFragment.h"
 #include "DocumentMarkerController.h"
 #include "EditingBoundary.h"
 #include "Editor.h"
 #include "EditorClient.h"
 #include "Element.h"
 #include "Frame.h"
 #include "htmlediting.h"
 #include "HTMLInputElement.h"
 #include "HTMLNames.h"
+#include "HTMLTextAreaElement.h"
 #include "NodeTraversal.h"
 #include "RenderTableCell.h"
 #include "Text.h"
 #include "VisibleUnits.h"
 
 namespace WebCore {
 
 using namespace HTMLNames;
 
 static bool isTableRow(const Node* node)
@@ skipping 734 matching lines @@
     // use the current ending selection.
     if (!m_hasSelectionToDelete)
         m_selectionToDelete = endingSelection();
 
     if (!m_selectionToDelete.isNonOrphanedRange())
         return;
 
     String originalString = originalStringForAutocorrectionAtBeginningOfSelection();
 
     // If the deletion is occurring in a text field, and we're not deleting to replace the selection, then let the frame call across the bridge to notify the form delegate. 
+    Element* textControl = enclosingTextFormControl(m_selectionToDelete.start());
     if (!m_replace) {
-        Element* textControl = enclosingTextFormControl(m_selectionToDelete.start());
         if (textControl && textControl->focused())
             document()->frame()->editor()->textWillBeDeletedInTextField(textControl);
     }
 
     // save this to later make the selection with
     EAffinity affinity = m_selectionToDelete.affinity();
     
     Position downstreamEnd = m_selectionToDelete.end().downstream();
     m_needPlaceholder = isStartOfParagraph(m_selectionToDelete.visibleStart(), CanCrossEditingBoundary)
             && isEndOfParagraph(m_selectionToDelete.visibleEnd(), CanCrossEditingBoundary)
-            && !lineBreakExistsAtVisiblePosition(m_selectionToDelete.visibleEnd());
+            && !lineBreakExistsAtVisiblePosition(m_selectionToDelete.visibleEnd())
+            && !isHTMLTextAreaElement(textControl) && !textControl->toInputElement();

[ojan, 2013/04/08 19:23:36]

If you're willing to try it out, I had a more general solution in mind that
would work for both text controls and more general use of contentEditable. 

Specifically, if you change the last line to:
&& !m_endingPosition.containerNode().isRootEditableElement();

That way, if you have <div contentEditable>a</div> and you delete the 'a', we
won't insert a <br> there either.

[aurimas (slooooooooow), 2013/04/09 21:54:21]

I tried adding !m_endingPosition.containerNode()->isRootEditableElement();
however it crashes when it tries to delete the last element in textarea. The
crash happens in WebKit/Source/WebCore/dom/Node.h:467

I also tried
enclosingTextFormControl(m_selectionToDelete.start())->isRootEditableElement();.
This did not crash in TextArea, but it crashed in ContentEditable when deleting
a node inside the ContentEditable. It crashed on the same line as the one above.

Any ideas how to get around it?

[leviw_travelin_and_unemployed, 2013/04/09 23:54:29]

Ojan, I think your change is correct, but simply violates one of many
assumptions elsewhere in editing code. More handy than the line this asserts on
would be a backtrace.

     if (m_needPlaceholder) {
         // Don't need a placeholder when deleting a selection that starts just before a table
         // and ends inside it (we do need placeholders to hold open empty cells, but that's
         // handled elsewhere).
         if (Node* table = isLastPositionBeforeTable(m_selectionToDelete.visibleStart()))
             if (m_selectionToDelete.end().deprecatedNode()->isDescendantOf(table))
                 m_needPlaceholder = false;
     }
         
     
@@ skipping 54 matching lines @@
 
 // Normally deletion doesn't preserve the typing style that was present before it.  For example,
 // type a character, Bold, then delete the character and start typing.  The Bold typing style shouldn't
 // stick around.  Deletion should preserve a typing style that *it* sets, however.
 bool DeleteSelectionCommand::preservesTypingStyle() const
 {
     return m_typingStyle;
 }
 
 } // namespace WebCore