Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 13532006: Check if a command can be executed before executing it via a shortcut. (Closed)

Created:
7 years, 8 months ago by mtomasz
Modified:
7 years, 8 months ago
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Check if a command can be executed before executing it via a shortcut. Commands are updated when focus is updated. This makes sense, when executing commands by pressing an ui element. However, when executing a command via a shortcut, we may execute it while it shouldn't be allowed to be executed. This patch fixes it by updating the command's state (disabled/enabled) just before executing it via a shortcut. TEST=Enter Files.app, select a file, then deselect a file, hit Delete button. A delete command should not be invoked. BUG=174554 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/webui/resources/js/cr/ui/command.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtomasz
@arv: PTAL. Thanks.
7 years, 8 months ago (2013-04-04 13:23:29 UTC) #1
arv (Not doing code reviews)
LGTM Makes sense
7 years, 8 months ago (2013-04-04 18:48:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/13532006/1
7 years, 8 months ago (2013-04-05 01:21:12 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 05:59:13 UTC) #4
Message was sent while issue was closed.
Change committed as 192514

Powered by Google App Engine
This is Rietveld 408576698