chrome/browser/media_galleries/fileapi/picasa/pmp_test_helper.h - Issue 13529028: PicasaAlbumTableReader for Media Galleries API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/picasa/pmp_test_helper.h

Issue 13529028: PicasaAlbumTableReader for Media Galleries API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0005-picasa-import-pmp-reader

Patch Set: Update gypi file to exclude test on android. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/picasa/pmp_table_reader_unittest.cc ('k') | chrome/browser/media_galleries/fileapi/picasa/pmp_test_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/picasa/pmp_test_helper.h

diff --git a/chrome/browser/media_galleries/fileapi/picasa/pmp_test_helper.h b/chrome/browser/media_galleries/fileapi/picasa/pmp_test_helper.h

index d675773bba192191dbbd8148aa016521d6914a5b..5cee53eeed91b5a45c546536394433a00b37ccab 100644

--- a/chrome/browser/media_galleries/fileapi/picasa/pmp_test_helper.h

+++ b/chrome/browser/media_galleries/fileapi/picasa/pmp_test_helper.h

@@ -22,20 +22,20 @@ class PmpColumnReader;

// A helper class used for unit tests only

class PmpTestHelper {

public:

- PmpTestHelper();

+ explicit PmpTestHelper(const std::string& table_name);

bool Init();

base::FilePath GetTempDirPath();

template<class T>

- bool WriteColumnFileFromVector(const std::string& table_name,

- const std::string& column_name,

+ bool WriteColumnFileFromVector(const std::string& column_name,

const PmpFieldType field_type,

const std::vector<T>& elements_vector);

bool InitColumnReaderFromBytes(PmpColumnReader* const reader,

const std::vector<uint8>& data,

+ const PmpFieldType expected_type,

uint32* rows_read);

static std::vector<uint8> MakeHeader(const PmpFieldType field_type,

@@ -47,6 +47,7 @@ class PmpTestHelper {

const std::vector<T>& elems);

private:

+ std::string table_name_;

base::ScopedTempDir temp_dir_;

};