PicasaAlbumTableReader for Media Galleries API

webkit/fileapi/media/picasa/pmp_albumdata_table_reader.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+

[vandebo (ex-Chrome), 2013/04/06 01:10:30]

nit: extra line

[tommycli, 2013/04/08 17:17:29]

Done.

+
+#ifndef WEBKIT_FILEAPI_MEDIA_PICASA_PMP_ALBUMDATA_TABLE_READER_H_
+#define WEBKIT_FILEAPI_MEDIA_PICASA_PMP_ALBUMDATA_TABLE_READER_H_
+
+#include "base/files/file_path.h"
+#include "webkit/fileapi/media/picasa/album_info.h"
+#include "webkit/fileapi/media/picasa/pmp_table_reader.h"
+#include "webkit/storage/webkit_storage_export.h"
+
+namespace picasaimport {
+
+class WEBKIT_STORAGE_EXPORT_PRIVATE PmpAlbumdataTableReader

[vandebo (ex-Chrome), 2013/04/06 01:10:30]

At this level, I think this is Picasa specific and not Pmp specific...
PicasaAlbums ?

[tommycli, 2013/04/08 17:17:29]

Done.

+    : public PmpTableReader {

[vandebo (ex-Chrome), 2013/04/06 01:10:30]

Does this need to inherit the table reader?  In general, we prefer composition
over inheritance.

[tommycli, 2013/04/08 17:17:29]

Done.

+ public:
+  PmpAlbumdataTableReader();
+  virtual ~PmpAlbumdataTableReader();
+
+  virtual bool Init(const base::FilePath& directory_path) OVERRIDE;
+
+  std::vector<AlbumInfo> folders() {

[vandebo (ex-Chrome), 2013/04/06 01:10:30]

If you're going to separate folders and user albums in the interface, is it
still useful to have the type in the AlbumInfo?

[tommycli, 2013/04/08 17:17:29]

Done.

+    return folders_;
+  }
+
+  std::vector<AlbumInfo> user_albums() {
+    return user_albums_;
+  }
+
+ private:
+  std::vector<AlbumInfo> folders_;

[vandebo (ex-Chrome), 2013/04/06 01:10:30]

Since you're storing all the data at this level, I don't think you want to even
have a table reader as a part of the class; Init should use one and then destroy
it.

[tommycli, 2013/04/08 17:17:29]

Done.

+  std::vector<AlbumInfo> user_albums_;
+
+  DISALLOW_COPY_AND_ASSIGN (PmpAlbumdataTableReader);
+};
+
+}  // namespace picasaimport
+
+#endif  // WEBKIT_FILEAPI_MEDIA_PICASA_PMP_ALBUMDATA_TABLE_READER_H_