Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 13529017: Remove unnecessary explicity prototype check. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/mips/stub-cache-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1095 matching lines...) Expand 10 before | Expand all | Expand 10 after
1106 1106
1107 1107
1108 void BaseLoadStubCompiler::NonexistentHandlerFrontend( 1108 void BaseLoadStubCompiler::NonexistentHandlerFrontend(
1109 Handle<JSObject> object, 1109 Handle<JSObject> object,
1110 Handle<JSObject> last, 1110 Handle<JSObject> last,
1111 Handle<Name> name, 1111 Handle<Name> name,
1112 Label* success, 1112 Label* success,
1113 Handle<GlobalObject> global) { 1113 Handle<GlobalObject> global) {
1114 Label miss; 1114 Label miss;
1115 1115
1116 Register reg = HandlerFrontendHeader(object, receiver(), last, name, &miss); 1116 HandlerFrontendHeader(object, receiver(), last, name, &miss);
1117 1117
1118 // If the last object in the prototype chain is a global object, 1118 // If the last object in the prototype chain is a global object,
1119 // check that the global property cell is empty. 1119 // check that the global property cell is empty.
1120 if (!global.is_null()) { 1120 if (!global.is_null()) {
1121 GenerateCheckPropertyCell(masm(), global, name, scratch2(), &miss); 1121 GenerateCheckPropertyCell(masm(), global, name, scratch2(), &miss);
1122 } 1122 }
1123 1123
1124 if (!last->HasFastProperties()) {
1125 __ mov(scratch2(), FieldOperand(reg, HeapObject::kMapOffset));
1126 __ mov(scratch2(), FieldOperand(scratch2(), Map::kPrototypeOffset));
1127 __ cmp(scratch2(), isolate()->factory()->null_value());
1128 __ j(not_equal, &miss);
1129 }
1130
1131 HandlerFrontendFooter(success, &miss); 1124 HandlerFrontendFooter(success, &miss);
1132 } 1125 }
1133 1126
1134 1127
1135 void BaseLoadStubCompiler::GenerateLoadField(Register reg, 1128 void BaseLoadStubCompiler::GenerateLoadField(Register reg,
1136 Handle<JSObject> holder, 1129 Handle<JSObject> holder,
1137 PropertyIndex index) { 1130 PropertyIndex index) {
1138 // Get the value from the properties. 1131 // Get the value from the properties.
1139 GenerateFastPropertyLoad(masm(), eax, reg, holder, index); 1132 GenerateFastPropertyLoad(masm(), eax, reg, holder, index);
1140 __ ret(0); 1133 __ ret(0);
(...skipping 2488 matching lines...) Expand 10 before | Expand all | Expand 10 after
3629 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3622 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3630 } 3623 }
3631 } 3624 }
3632 3625
3633 3626
3634 #undef __ 3627 #undef __
3635 3628
3636 } } // namespace v8::internal 3629 } } // namespace v8::internal
3637 3630
3638 #endif // V8_TARGET_ARCH_IA32 3631 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/mips/stub-cache-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698