Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13524003: [StorageMonitor] Remove GetStorageSize. (Closed)

Created:
7 years, 8 months ago by Greg Billock
Modified:
7 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, sail+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[StorageMonitor] Remove GetStorageSize. Use GetStorageInfoForPath to get volume size. R=thestig@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192978

Patch Set 1 #

Patch Set 2 : Fix tests, volume mount watcher #

Patch Set 3 : Pass info #

Patch Set 4 : Compiling... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -87 lines) Patch
M chrome/browser/storage_monitor/media_storage_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/storage_monitor.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_chromeos.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_chromeos.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_chromeos_unittest.cc View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_linux.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_linux.cc View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc View 1 2 2 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_mac.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_mac.mm View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_mac_unittest.mm View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_win.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_win.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/storage_monitor/test_storage_monitor.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/storage_monitor/test_storage_monitor.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/storage_monitor/volume_mount_watcher_win.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/storage_monitor/volume_mount_watcher_win.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Greg Billock
7 years, 8 months ago (2013-04-06 00:51:01 UTC) #1
Lei Zhang
Can you remove VolumeMountWatcherWin::GetStorageSize() as well?
7 years, 8 months ago (2013-04-06 01:01:02 UTC) #2
Greg Billock
On 2013/04/06 01:01:02, Lei Zhang wrote: > Can you remove VolumeMountWatcherWin::GetStorageSize() as well? Done
7 years, 8 months ago (2013-04-06 01:35:56 UTC) #3
Lei Zhang
lgtm
7 years, 8 months ago (2013-04-06 01:39:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/13524003/17001
7 years, 8 months ago (2013-04-06 21:23:37 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=115701
7 years, 8 months ago (2013-04-06 23:06:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/13524003/17001
7 years, 8 months ago (2013-04-08 17:18:52 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 17:22:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/13524003/17001
7 years, 8 months ago (2013-04-09 01:02:52 UTC) #9
commit-bot: I haz the power
7 years, 8 months ago (2013-04-09 01:39:57 UTC) #10
Message was sent while issue was closed. 
Change committed as 192978

Powered by Google App Engine
This is Rietveld 408576698