Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 13523005: Performance guidelines for decl. WebRequest API (Closed)

Created:
7 years, 8 months ago by battre
Modified:
7 years, 8 months ago
Reviewers:
Mike West
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, vabr (Chromium)
Visibility:
Public.

Description

Performance guidelines for decl. WebRequest API Provide performance guidelines for the declarative WebRequest API. BUG=227523 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192825

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added examples #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M chrome/common/extensions/docs/templates/intros/declarativeWebRequest.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/events.html View 1 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
battre
Hi Mike, can you please review this CL? Thanks, Dominic
7 years, 8 months ago (2013-04-08 13:06:33 UTC) #1
Mike West
Thanks! One note: https://codereview.chromium.org/13523005/diff/1/chrome/common/extensions/docs/templates/intros/events.html File chrome/common/extensions/docs/templates/intros/events.html (right): https://codereview.chromium.org/13523005/diff/1/chrome/common/extensions/docs/templates/intros/events.html#newcode172 chrome/common/extensions/docs/templates/intros/events.html:172: mind: These are excellent tips: I ...
7 years, 8 months ago (2013-04-08 13:52:53 UTC) #2
battre
PTAL https://codereview.chromium.org/13523005/diff/1/chrome/common/extensions/docs/templates/intros/events.html File chrome/common/extensions/docs/templates/intros/events.html (right): https://codereview.chromium.org/13523005/diff/1/chrome/common/extensions/docs/templates/intros/events.html#newcode172 chrome/common/extensions/docs/templates/intros/events.html:172: mind: On 2013/04/08 13:52:53, Mike West (chromium) wrote: ...
7 years, 8 months ago (2013-04-08 14:42:55 UTC) #3
Mike West
On 2013/04/08 14:42:55, battre wrote: > PTAL LGTM! Thanks. :)
7 years, 8 months ago (2013-04-08 15:26:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/13523005/4001
7 years, 8 months ago (2013-04-08 16:05:39 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-08 16:10:33 UTC) #6
Message was sent while issue was closed.
Change committed as 192825

Powered by Google App Engine
This is Rietveld 408576698