Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 13523004: StartDragAndDrop should return the completed operation (Closed)

Created:
7 years, 8 months ago by ckocagil
Modified:
7 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, dcheng, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

StartDragAndDrop should return the completed operation, not the set of allowed operations BUG=227332 TEST=Drag-drop operations on Win Aura shouldn't crash the renderer or hit asserts Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ckocagil
Could you try reproducing the bug first?
7 years, 8 months ago (2013-04-06 08:45:41 UTC) #1
jam
I'm not an owner here.
7 years, 8 months ago (2013-04-08 15:50:39 UTC) #2
ckocagil
7 years, 8 months ago (2013-04-08 17:35:05 UTC) #3
sky
LGTM
7 years, 8 months ago (2013-04-08 19:45:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/13523004/1
7 years, 8 months ago (2013-04-08 20:00:42 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-09 00:00:09 UTC) #6
Message was sent while issue was closed.
Change committed as 192954

Powered by Google App Engine
This is Rietveld 408576698