Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135183008: First group of routing examples (Closed)

Created:
6 years, 11 months ago by shailentuli
Modified:
6 years, 11 months ago
Reviewers:
pavelj
Base URL:
https://github.com/dart-lang/dart_by_example.git@master
Visibility:
Public.

Description

First group of routing examples Committed: c17396b

Patch Set 1 #

Total comments: 4

Patch Set 2 : Got rid of ng-bind-route #

Patch Set 3 : Tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -30 lines) Patch
A example/angular/routing/accessing_route_params_within_components/book.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A example/angular/routing/accessing_route_params_within_components/book_component.dart View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A + example/angular/routing/accessing_route_params_within_components/book_component.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A + example/angular/routing/accessing_route_params_within_components/index.html View 1 2 1 chunk +5 lines, -8 lines 0 comments Download
A example/angular/routing/accessing_route_params_within_components/main.dart View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A + example/angular/routing/accessing_route_params_within_components/my_controller.dart View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
A example/angular/routing/accessing_route_params_within_components/my_router.dart View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A example/angular/routing/accessing_route_params_within_components/views/show_book.html View 1 chunk +1 line, -0 lines 0 comments Download
A example/angular/routing/accessing_router_in_controller/book.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A + example/angular/routing/accessing_router_in_controller/index.html View 1 1 chunk +5 lines, -3 lines 0 comments Download
A example/angular/routing/accessing_router_in_controller/main.dart View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A example/angular/routing/accessing_router_in_controller/my_controller.dart View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A example/angular/routing/accessing_router_in_controller/my_router.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A + example/angular/routing/accessing_router_in_controller/views/show_book.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + example/angular/routing/nesting_routes/index.html View 1 2 1 chunk +6 lines, -1 line 0 comments Download
A example/angular/routing/nesting_routes/main.dart View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A example/angular/routing/nesting_routes/my_router.dart View 1 chunk +21 lines, -0 lines 0 comments Download
A example/angular/routing/nesting_routes/views/all_articles.html View 1 chunk +6 lines, -0 lines 0 comments Download
A example/angular/routing/nesting_routes/views/featured_article.html View 1 chunk +3 lines, -0 lines 0 comments Download
A + example/angular/routing/redirecting_to_a_new_route/index.html View 1 chunk +4 lines, -2 lines 0 comments Download
A example/angular/routing/redirecting_to_a_new_route/main.dart View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A + example/angular/routing/redirecting_to_a_new_route/my_controller.dart View 1 2 1 chunk +14 lines, -4 lines 0 comments Download
A example/angular/routing/redirecting_to_a_new_route/my_router.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A example/angular/routing/redirecting_to_a_new_route/views/about.html View 1 chunk +3 lines, -0 lines 0 comments Download
A example/angular/routing/redirecting_to_a_new_route/views/bio.html View 1 chunk +3 lines, -0 lines 0 comments Download
A + example/angular/routing/setting_up_a_default_view/index.html View 1 2 1 chunk +6 lines, -1 line 0 comments Download
A example/angular/routing/setting_up_a_default_view/main.dart View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A example/angular/routing/setting_up_a_default_view/my_router.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A example/angular/routing/setting_up_a_default_view/views/default.html View 1 chunk +1 line, -0 lines 0 comments Download
A example/angular/routing/setting_up_a_default_view/views/hello.html View 1 chunk +1 line, -0 lines 0 comments Download
A + example/angular/routing/setting_up_simple_routing/index.html View 1 2 1 chunk +6 lines, -1 line 0 comments Download
A example/angular/routing/setting_up_simple_routing/main.dart View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A example/angular/routing/setting_up_simple_routing/my_router.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A example/angular/routing/setting_up_simple_routing/views/goodbye.html View 1 chunk +1 line, -0 lines 0 comments Download
A example/angular/routing/setting_up_simple_routing/views/hello.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
shailentuli
This CL contains the first set of Angular Dart routing examples. Misko suggested I get ...
6 years, 11 months ago (2014-01-21 21:36:09 UTC) #1
pavelj
https://chromiumcodereview.appspot.com/135183008/diff/1/example/angular/routing/accessing_route_params_within_components/book_component.dart File example/angular/routing/accessing_route_params_within_components/book_component.dart (right): https://chromiumcodereview.appspot.com/135183008/diff/1/example/angular/routing/accessing_route_params_within_components/book_component.dart#newcode12 example/angular/routing/accessing_route_params_within_components/book_component.dart:12: templateUrl: './book_component.html', remove ./ ? https://chromiumcodereview.appspot.com/135183008/diff/1/example/angular/routing/accessing_route_params_within_components/book_component.dart#newcode13 example/angular/routing/accessing_route_params_within_components/book_component.dart:13: publishAs: 'cmp' ...
6 years, 11 months ago (2014-01-21 21:59:59 UTC) #2
shailentuli
6 years, 11 months ago (2014-01-23 02:02:20 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as rc17396b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698