Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2224)

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.h

Issue 13517002: Support shared workers as debug targets for chrome.debugger API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fresh patch for a new trybot run. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/debugger/debugger_api.h
diff --git a/chrome/browser/extensions/api/debugger/debugger_api.h b/chrome/browser/extensions/api/debugger/debugger_api.h
index d56bb15a5ad8b2c99d66262e39a868913884f6d3..c2fc6610281d64264547c34031a65e30db1b08d8 100644
--- a/chrome/browser/extensions/api/debugger/debugger_api.h
+++ b/chrome/browser/extensions/api/debugger/debugger_api.h
@@ -24,7 +24,7 @@ class DictionaryValue;
}
namespace content {
-class DevToolsClientHost;
+class DevToolsAgentHost;
class WebContents;
}
@@ -35,11 +35,11 @@ class DebuggerFunction : public AsyncExtensionFunction {
void FormatErrorMessage(const std::string& format);
- bool InitWebContents();
+ bool InitAgentHost();
bool InitClientHost();
- content::WebContents* contents_;
Debuggee debuggee_;
+ content::DevToolsAgentHost* agent_host_;
yurys 2013/04/03 14:19:57 Should it be scoped_ref<DevToolsAgentHost> ?
Vladislav Kaznacheev 2013/04/03 14:54:36 It is guaranteed to live long enough, but I agree
ExtensionDevToolsClientHost* client_host_;
};
@@ -98,6 +98,11 @@ class DebuggerGetTargetsFunction : public DebuggerFunction {
// ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
+
+ private:
+ void CollectWorkerInfo(base::ListValue* list);
+
+ void SendTargetList(base::ListValue* list);
};
#endif // CHROME_BROWSER_EXTENSIONS_API_DEBUGGER_DEBUGGER_API_H_

Powered by Google App Engine
This is Rietveld 408576698