Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 13513004: content: Move more constants into content namespace. (Closed)

Created:
7 years, 8 months ago by tfarina
Modified:
7 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, cbentzel+watch_chromium.org, ctguil+watch_chromium.org, gavinp+disk_chromium.org, hashimoto+watch_chromium.org, feature-media-reviews_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, apatrick_chromium, chromium-apps-reviews_chromium.org, James Su, zork+watch_chromium.org
Visibility:
Public.

Description

content: Move more constants into content namespace. R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194115

Patch Set 1 #

Total comments: 2

Patch Set 2 : sort #

Patch Set 3 : rebase #

Patch Set 4 : fix #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -50 lines) Patch
M chrome/browser/autocomplete/builtin_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/browser_about_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/accessibility_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_internals_ui.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/media/media_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/view_blob_internals_job_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/view_http_cache_job_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/web_contents/debug_urls.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/content_web_ui_controller_factory.cc View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M content/browser/webui/shared_resources_data_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/url_constants.h View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M content/public/common/url_constants.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
7 years, 8 months ago (2013-04-08 00:19:07 UTC) #1
jam
lgtm https://codereview.chromium.org/13513004/diff/1/chrome/browser/browser_about_handler.cc File chrome/browser/browser_about_handler.cc (right): https://codereview.chromium.org/13513004/diff/1/chrome/browser/browser_about_handler.cc#newcode24 chrome/browser/browser_about_handler.cc:24: content::kChromeUIAccessibilityHost, nit: this array should be sorted now
7 years, 8 months ago (2013-04-08 18:10:33 UTC) #2
tfarina
https://codereview.chromium.org/13513004/diff/1/chrome/browser/browser_about_handler.cc File chrome/browser/browser_about_handler.cc (right): https://codereview.chromium.org/13513004/diff/1/chrome/browser/browser_about_handler.cc#newcode24 chrome/browser/browser_about_handler.cc:24: content::kChromeUIAccessibilityHost, On 2013/04/08 18:10:33, jam wrote: > nit: this ...
7 years, 8 months ago (2013-04-09 02:18:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/13513004/17001
7 years, 8 months ago (2013-04-13 13:23:59 UTC) #4
commit-bot: I haz the power
Failed to apply patch for content/browser/indexed_db/indexed_db_internals_ui.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 8 months ago (2013-04-13 13:24:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/13513004/23001
7 years, 8 months ago (2013-04-14 01:30:20 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-14 02:47:57 UTC) #7
Message was sent while issue was closed.
Change committed as 194115

Powered by Google App Engine
This is Rietveld 408576698