git_cl.py - Issue 13513002: Fix a case branch...rietveldissue is None.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 13513002: Fix a case branch...rietveldissue is None. (Closed) Base URL: http://git.chromium.org/chromium/tools/depot_tools.git@master

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index f836a0501f82119c3fccae9cab94b3b587efe55e..e20de825608befe6ae0c26628499df8c85e5bb76 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -1293,7 +1293,7 @@ def CMDupload(parser, args):

if cl.GetIssue():

latest_patchset = cl.GetMostRecentPatchset(cl.GetIssue())

local_patchset = cl.GetPatchset()

- if local_patchset != latest_patchset:

+ if latest_patchset and local_patchset and local_patchset != latest_patchset:

print ('The last upload made from this repository was patchset #%d but '

'the most recent patchset on the server is #%d.'

% (local_patchset, latest_patchset))

« no previous file with comments | « no previous file | no next file » | no next file with comments »