google_apis: Introduce AddNewFile() and SetLastModifiedTime() in FakeDriveService

google_apis: Introduce AddNewFile() and SetLastModifiedTime() in FakeDriveService

This is in preparation for adding browser tests for Drive in Files.app

BUG=224534
TEST=none; just added some more test code


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192260

[kinaba, 2013-04-03 08:17:33]

https://codereview.chromium.org/13510003/diff/1/chrome/browser/google_apis/fa...
File chrome/browser/google_apis/fake_drive_service.cc (right):

https://codereview.chromium.org/13510003/diff/1/chrome/browser/google_apis/fa...
chrome/browser/google_apis/fake_drive_service.cc:993: base::Bind(callback,
HTTP_CREATED, base::Passed(&parsed_entry)));
Header comment says it returns HTTP_SUCCESS rather than HTTP_CREATED.
I think HTTP_SUCCESS is more appropriate.

https://codereview.chromium.org/13510003/diff/1/chrome/browser/google_apis/fa...
File chrome/browser/google_apis/fake_drive_service_unittest.cc (right):

https://codereview.chromium.org/13510003/diff/1/chrome/browser/google_apis/fa...
chrome/browser/google_apis/fake_drive_service_unittest.cc:1597:
EXPECT_EQ(HTTP_CREATED, error);
HTTP_SUCCESS?

[satorux1, 2013-04-03 08:33:32]

https://codereview.chromium.org/13510003/diff/1/chrome/browser/google_apis/fa...
File chrome/browser/google_apis/fake_drive_service.cc (right):

https://codereview.chromium.org/13510003/diff/1/chrome/browser/google_apis/fa...
chrome/browser/google_apis/fake_drive_service.cc:993: base::Bind(callback,
HTTP_CREATED, base::Passed(&parsed_entry)));
On 2013/04/03 08:17:33, kinaba wrote:
> Header comment says it returns HTTP_SUCCESS rather than HTTP_CREATED.
> I think HTTP_SUCCESS is more appropriate.

oops. you are right! fixed

https://codereview.chromium.org/13510003/diff/1/chrome/browser/google_apis/fa...
File chrome/browser/google_apis/fake_drive_service_unittest.cc (right):

https://codereview.chromium.org/13510003/diff/1/chrome/browser/google_apis/fa...
chrome/browser/google_apis/fake_drive_service_unittest.cc:1597:
EXPECT_EQ(HTTP_CREATED, error);
On 2013/04/03 08:17:33, kinaba wrote:
> HTTP_SUCCESS?

Done.

[kinaba, 2013-04-03 08:38:53]

lgtm!

[commit-bot: I haz the power, 2013-04-04 03:40:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/13510003/12001

[commit-bot: I haz the power, 2013-04-04 09:25:10]

Change committed as 192260