Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13509006: Add UX for languages that don't have any associated input method (Closed)

Created:
7 years, 8 months ago by Zachary Kuznia
Modified:
7 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add UX for languages that don't have any associated input method BUG=172195 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193333

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix nits #

Patch Set 3 : Remove deprecated test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -96 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/language_options.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/language_options.js View 1 4 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 1 3 chunks +26 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/language_options_handler_unittest.cc View 1 2 1 chunk +0 lines, -94 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Zachary Kuznia
7 years, 8 months ago (2013-04-03 09:25:36 UTC) #1
Seigo Nonaka
lgtm
7 years, 8 months ago (2013-04-03 09:41:49 UTC) #2
Zachary Kuznia
Hello James, Could you do an OWNERS review of this? Thanks, -Zach
7 years, 8 months ago (2013-04-03 09:43:56 UTC) #3
James Hawkins
LGTM with nits. https://codereview.chromium.org/13509006/diff/1/chrome/browser/resources/options/language_options.html File chrome/browser/resources/options/language_options.html (right): https://codereview.chromium.org/13509006/diff/1/chrome/browser/resources/options/language_options.html#newcode88 chrome/browser/resources/options/language_options.html:88: i18n-content="no_input_methods" hidden> nit: i18n-content should be ...
7 years, 8 months ago (2013-04-05 18:41:50 UTC) #4
Zachary Kuznia
https://codereview.chromium.org/13509006/diff/1/chrome/browser/resources/options/language_options.html File chrome/browser/resources/options/language_options.html (right): https://codereview.chromium.org/13509006/diff/1/chrome/browser/resources/options/language_options.html#newcode88 chrome/browser/resources/options/language_options.html:88: i18n-content="no_input_methods" hidden> On 2013/04/05 18:41:50, James Hawkins wrote: > ...
7 years, 8 months ago (2013-04-09 06:45:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/13509006/7001
7 years, 8 months ago (2013-04-09 06:46:19 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=100966
7 years, 8 months ago (2013-04-09 07:42:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/13509006/21001
7 years, 8 months ago (2013-04-09 13:39:07 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101099
7 years, 8 months ago (2013-04-09 14:32:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/13509006/21001
7 years, 8 months ago (2013-04-09 20:39:07 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101336
7 years, 8 months ago (2013-04-09 21:55:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/13509006/21001
7 years, 8 months ago (2013-04-09 22:50:21 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101412
7 years, 8 months ago (2013-04-10 00:11:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/13509006/21001
7 years, 8 months ago (2013-04-10 06:05:39 UTC) #14
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 06:30:50 UTC) #15
Message was sent while issue was closed. 
Change committed as 193333

Powered by Google App Engine
This is Rietveld 408576698