Update chrome.power example extension.

Update chrome.power example extension.

This renames some "level" variables to "state" to make it
more clear that they don't directly map to the API's "level"
enum.  It also registers chrome.runtime.onStartup and
chrome.windows.onCreated (to work around onStartup apparently
not firing on Chrome OS) listeners and switches from
localStorage to chrome.storage.local.

BUG=none


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192992

[Matt Perry, 2013-04-08 21:00:22]

https://codereview.chromium.org/13493019/diff/6001/chrome/common/extensions/d...
File chrome/common/extensions/docs/examples/api/power/background.js (right):

https://codereview.chromium.org/13493019/diff/6001/chrome/common/extensions/d...
chrome/common/extensions/docs/examples/api/power/background.js:30: if (STATE_KEY
in localStorage) {
We're trying to move away from localStorage. Can you use the
chrome.storage.local API instead? You'll have to change getSavedState to be
asynchronous and accept a callback.

See https://developer.chrome.com/trunk/extensions/storage.html

[Daniel Erat, 2013-04-08 21:40:37]

Thanks, another look?

[Matt Perry, 2013-04-08 21:44:33]

lgtm

https://codereview.chromium.org/13493019/diff/14001/chrome/common/extensions/...
File chrome/common/extensions/docs/examples/api/power/background.js (right):

https://codereview.chromium.org/13493019/diff/14001/chrome/common/extensions/...
chrome/common/extensions/docs/examples/api/power/background.js:79:
chrome.storage.local.set(items);
nit: could also do set({STATE_KEY: newState});

[Daniel Erat, 2013-04-08 21:50:18]

https://codereview.chromium.org/13493019/diff/14001/chrome/common/extensions/...
File chrome/common/extensions/docs/examples/api/power/background.js (right):

https://codereview.chromium.org/13493019/diff/14001/chrome/common/extensions/...
chrome/common/extensions/docs/examples/api/power/background.js:79:
chrome.storage.local.set(items);
On 2013/04/08 21:44:33, Matt Perry wrote:
> nit: could also do set({STATE_KEY: newState});

I made this same mistake: STATE_KEY is a variable, so I think I'd need to do
{state: newState} instead, right?  Hate JavaScript so much.

[Matt Perry, 2013-04-08 21:51:55]

https://codereview.chromium.org/13493019/diff/14001/chrome/common/extensions/...
File chrome/common/extensions/docs/examples/api/power/background.js (right):

https://codereview.chromium.org/13493019/diff/14001/chrome/common/extensions/...
chrome/common/extensions/docs/examples/api/power/background.js:79:
chrome.storage.local.set(items);
On 2013/04/08 21:50:18, Daniel Erat wrote:
> On 2013/04/08 21:44:33, Matt Perry wrote:
> > nit: could also do set({STATE_KEY: newState});
> 
> I made this same mistake: STATE_KEY is a variable, so I think I'd need to do
> {state: newState} instead, right?  Hate JavaScript so much.

Oops! You're right.

[commit-bot: I haz the power, 2013-04-08 22:30:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/13493019/14001

[commit-bot: I haz the power, 2013-04-08 23:57:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/13493019/28001

[commit-bot: I haz the power, 2013-04-09 03:12:09]

Change committed as 192992