Add UMA tracing for unsupported codecs

Add UMA tracing for unsupported codecs

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195247

[jrummell, 2013-04-08 19:51:34]

PTAL. This only logs codecs that aren't supported as long as FFmpeg can handle
the container.

[scherkus (not reviewing), 2013-04-10 00:27:25]

what if we were to blindly log every audio/video FFmpeg CodecID we after
FFmpegDemuxer finishes initializing?

it wouldn't distinguish between unsupported vs supported, but it would be less
invasive and also capture CodecIDs that don't have a mapping to/from Chromium's
Audio/VideoCodec enum.

[jrummell, 2013-04-15 21:29:24]

Updated to log all codecs detected by FFmpeg, plus add the histogram
annotations.

[Ilya Sherman, 2013-04-16 00:51:31]

histograms usage LGTM with a couple of suggestions:

https://codereview.chromium.org/13493018/diff/8001/tools/metrics/histograms/h...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/13493018/diff/8001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:480: <histogram
name="Media.DetectedVideoCodec" enum="FFmpegCodecs">
nit: Does FFmpeg distinguish between audio and video codecs?  It would be
slightly nicer to split this enumeration into two, unless that would introduce a
lot of redundancy for codecs that handle both audio and video or something like
that.

https://codereview.chromium.org/13493018/diff/8001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:4251: <int value="0"
label="AV_CODEC_ID_NONE"/>
nit: I'd recommend omitting the "AV_CODEC_ID_" prefix for all of these.

[jrummell, 2013-04-16 01:48:16]

Changes to the histogram labels.

https://codereview.chromium.org/13493018/diff/8001/tools/metrics/histograms/h...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/13493018/diff/8001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:480: <histogram
name="Media.DetectedVideoCodec" enum="FFmpegCodecs">
On 2013/04/16 00:51:31, Ilya Sherman wrote:
> nit: Does FFmpeg distinguish between audio and video codecs?  It would be
> slightly nicer to split this enumeration into two, unless that would introduce
a
> lot of redundancy for codecs that handle both audio and video or something
like
> that.

There doesn't appear to be any easy way of splitting them into 2 lists. FFmpeg
has a single enumeration.

https://codereview.chromium.org/13493018/diff/8001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:4251: <int value="0"
label="AV_CODEC_ID_NONE"/>
On 2013/04/16 00:51:31, Ilya Sherman wrote:
> nit: I'd recommend omitting the "AV_CODEC_ID_" prefix for all of these.

Done.

[scherkus (not reviewing), 2013-04-16 23:50:34]

lgtm

[commit-bot: I haz the power, 2013-04-18 18:47:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jrummell@chromium.org/13493018/14001

[commit-bot: I haz the power, 2013-04-18 22:48:44]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-04-19 17:43:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jrummell@chromium.org/13493018/14001

[commit-bot: I haz the power, 2013-04-19 18:45:46]

Change committed as 195247