Apps v2 in Pepper: Add C/C++ definition for chrome.socket.

Apps v2 in Pepper: Add C/C++ definition for chrome.socket.

BUG=226303
TEST=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192897

[yzshen1, 2013-04-04 00:57:14]

Hi, Raymes.

Would you please take a look? The CL simply applies the rules of mapping JS API
to C/C++ API. (I wish we already have the auto generator.)

I added a few more specializations in to/from_var_converter.h.

Thanks!

[raymes, 2013-04-04 03:31:45]

Ah!! I guess this work is higher priority than writing the generator?
Will the generator be the next thing on the list after sockets API?

On Wed, Apr 3, 2013 at 5:57 PM,  <yzshen@chromium.org> wrote:
> Reviewers: raymes,
>
> Message:
> Hi, Raymes.
>
> Would you please take a look? The CL simply applies the rules of mapping JS
> API
> to C/C++ API. (I wish we already have the auto generator.)
>
> I added a few more specializations in to/from_var_converter.h.
>
> Thanks!
>
> Description:
> Apps v2 in Pepper: Add C/C++ definition for chrome.socket.
>
> BUG=226303
> TEST=None
>
>
> Please review this at https://codereview.chromium.org/13490003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M ppapi/PRESUBMIT.py
>   A ppapi/api/extensions/dev/ppb_ext_socket_dev.idl
>   A ppapi/c/extensions/dev/ppb_ext_socket_dev.h
>   A ppapi/cpp/extensions/dev/socket_dev.h
>   A ppapi/cpp/extensions/dev/socket_dev.cc
>   M ppapi/cpp/extensions/from_var_converter.h
>   M ppapi/cpp/extensions/to_var_converter.h
>   M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
>   M ppapi/ppapi_sources.gypi
>   M ppapi/tests/all_c_includes.h
>   M ppapi/tests/all_cpp_includes.h
>
>

[yzshen, 2013-04-04 05:00:21]

On Wed, Apr 3, 2013 at 8:31 PM, Raymes Khoury <raymes@chromium.org> wrote:

> Ah!! I guess this work is higher priority than writing the generator?
>
Right.


> Will the generator be the next thing on the list after sockets API?
>
I hope so, if nothing more urgent emerges. :)

>
> On Wed, Apr 3, 2013 at 5:57 PM,  <yzshen@chromium.org> wrote:
> > Reviewers: raymes,
> >
> > Message:
> > Hi, Raymes.
> >
> > Would you please take a look? The CL simply applies the rules of mapping
> JS
> > API
> > to C/C++ API. (I wish we already have the auto generator.)
> >
> > I added a few more specializations in to/from_var_converter.h.
> >
> > Thanks!
> >
> > Description:
> > Apps v2 in Pepper: Add C/C++ definition for chrome.socket.
> >
> > BUG=226303
> > TEST=None
> >
> >
> > Please review this at https://codereview.chromium.org/13490003/
> >
> > SVN Base: svn://svn.chromium.org/chrome/trunk/src
> >
> > Affected files:
> >   M ppapi/PRESUBMIT.py
> >   A ppapi/api/extensions/dev/ppb_ext_socket_dev.idl
> >   A ppapi/c/extensions/dev/ppb_ext_socket_dev.h
> >   A ppapi/cpp/extensions/dev/socket_dev.h
> >   A ppapi/cpp/extensions/dev/socket_dev.cc
> >   M ppapi/cpp/extensions/from_var_converter.h
> >   M ppapi/cpp/extensions/to_var_converter.h
> >   M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
> >   M ppapi/ppapi_sources.gypi
> >   M ppapi/tests/all_c_includes.h
> >   M ppapi/tests/all_cpp_includes.h
> >
> >
>



-- 
Best regards,
Yuzhu Shen.

[Wez, 2013-04-05 00:07:53]

This API seems to copy the BSD-sockets approach of conflating TCP stream, TCP
listening, UDP sockets as a single type of resource, despite their having
different semantics.

What's the reasoning for that approach?

[yzshen, 2013-04-05 00:17:53]

Thanks!

This is the exact C/C++ translation of the JavaScript chrome.socket API.
Since the purpose here is to expose chrome.socket to Pepper plugins, I
don't think it is a good idea to try to improve the API and result in any
syntactic/semantic difference.

I am not sure why the JavaScript API was designed this way, maybe we could
talk with the original designer?
However, I expect that it is hard to re-design the API, since it is already
marked as a stable API.




On Thu, Apr 4, 2013 at 5:07 PM, <wez@chromium.org> wrote:

> This API seems to copy the BSD-sockets approach of conflating TCP stream,
> TCP
> listening, UDP sockets as a single type of resource, despite their having
> different semantics.
>
> What's the reasoning for that approach?
>
>
https://codereview.chromium.**org/13490003/<https://codereview.chromium.org/1...
>



-- 
Best regards,
Yuzhu Shen.

[raymes, 2013-04-08 01:59:48]

lgtm with one comment

https://codereview.chromium.org/13490003/diff/3012/ppapi/cpp/extensions/dev/s...
File ppapi/cpp/extensions/dev/socket_dev.cc (right):

https://codereview.chromium.org/13490003/diff/3012/ppapi/cpp/extensions/dev/s...
ppapi/cpp/extensions/dev/socket_dev.cc:190: const char* const
RecvFromInfo_Dev::kResultCode = "result_code";
should this be "resultCode" ?

[yzshen1, 2013-04-08 16:31:08]

https://codereview.chromium.org/13490003/diff/3012/ppapi/cpp/extensions/dev/s...
File ppapi/cpp/extensions/dev/socket_dev.cc (right):

https://codereview.chromium.org/13490003/diff/3012/ppapi/cpp/extensions/dev/s...
ppapi/cpp/extensions/dev/socket_dev.cc:190: const char* const
RecvFromInfo_Dev::kResultCode = "result_code";
Good catch! :)

On 2013/04/08 01:59:48, raymes wrote:
> should this be "resultCode" ?

[commit-bot: I haz the power, 2013-04-08 16:31:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/13490003/14001

[commit-bot: I haz the power, 2013-04-08 16:38:31]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-08 18:00:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/13490003/14001

[commit-bot: I haz the power, 2013-04-08 19:38:18]

Retried try job too often on mac_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-04-08 20:32:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/13490003/14001

[commit-bot: I haz the power, 2013-04-08 21:17:11]

Change committed as 192897