Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 13489004: Make apk_install.py check input md5 (Closed)

Created:
7 years, 8 months ago by cjhopman
Modified:
7 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Make apk_install.py check input md5 Since we have to always trigger the apk install action, we should only reinstall the apk when it doesn't match the one (we think) is installed to the device. BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192457

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M build/android/gyp/apk_install.py View 2 chunks +13 lines, -1 line 2 comments Download

Messages

Total messages: 6 (0 generated)
cjhopman
7 years, 8 months ago (2013-04-04 01:25:56 UTC) #1
newt (away)
can't review, as I can't find md5_check.py :( https://codereview.chromium.org/13489004/diff/2001/build/android/gyp/apk_install.py File build/android/gyp/apk_install.py (right): https://codereview.chromium.org/13489004/diff/2001/build/android/gyp/apk_install.py#newcode17 build/android/gyp/apk_install.py:17: from ...
7 years, 8 months ago (2013-04-04 03:07:08 UTC) #2
cjhopman
https://codereview.chromium.org/13489004/diff/2001/build/android/gyp/apk_install.py File build/android/gyp/apk_install.py (right): https://codereview.chromium.org/13489004/diff/2001/build/android/gyp/apk_install.py#newcode17 build/android/gyp/apk_install.py:17: from util import md5_check On 2013/04/04 03:07:08, newt wrote: ...
7 years, 8 months ago (2013-04-04 15:29:58 UTC) #3
newt (away)
lgtm
7 years, 8 months ago (2013-04-04 22:04:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13489004/2001
7 years, 8 months ago (2013-04-05 00:12:37 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 02:37:21 UTC) #6
Message was sent while issue was closed.
Change committed as 192457

Powered by Google App Engine
This is Rietveld 408576698