Remove application locale cache in autofill code.

components/autofill/browser/autofill_country.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/browser/autofill_country.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <map>
 #include <utility>
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/singleton.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
 #include "base/threading/thread_checker.h"
 #include "base/utf_string_conversions.h"
-#include "content/public/browser/browser_thread.h"
-#include "content/public/browser/content_browser_client.h"
 #include "grit/generated_resources.h"
 #include "third_party/icu/public/common/unicode/locid.h"
 #include "third_party/icu/public/common/unicode/uloc.h"
 #include "third_party/icu/public/common/unicode/unistr.h"
 #include "third_party/icu/public/common/unicode/urename.h"
 #include "third_party/icu/public/common/unicode/utypes.h"
 #include "third_party/icu/public/i18n/unicode/coll.h"
 #include "third_party/icu/public/i18n/unicode/ucol.h"
 #include "ui/base/l10n/l10n_util.h"
 
-using content::BrowserThread;
-
 namespace {
 
 // The maximum capacity needed to store a locale up to the country code.
 const size_t kLocaleCapacity =
     ULOC_LANG_CAPACITY + ULOC_SCRIPT_CAPACITY + ULOC_COUNTRY_CAPACITY + 1;
 
 struct CountryData {
   int postal_code_label_id;
   int state_label_id;
   AddressRequiredFields address_required_fields;
@@ skipping 795 matching lines @@
     const std::string& country_code) {
   return GetInstance()->country_data_.find(country_code);
 }
 
 // A singleton class that encapsulates mappings from country names to their
 // corresponding country codes.
 class CountryNames {
  public:
   static CountryNames* GetInstance();
 
-  // Returns the application locale.
-  const std::string ApplicationLocale();
-
   // Returns the country code corresponding to |country|, which should be a
   // country code or country name localized to |locale|.
   const std::string GetCountryCode(const string16& country,
                                    const std::string& locale);
 
  private:
   CountryNames();
   ~CountryNames();
   friend struct DefaultSingletonTraits<CountryNames>;
 
@@ skipping 31 matching lines @@
   // to the target localized country name.
   std::map<std::string, std::map<std::string, std::string> >
       locales_to_localized_names_;
 
   // Maps ICU locale names to their corresponding collators.
   std::map<std::string, icu::Collator*> collators_;
 
   // Verifies thread-safety of accesses to the application locale.
   base::ThreadChecker thread_checker_;
 
-  // Caches the application locale, for thread-safe access.
-  std::string application_locale_;
-
   DISALLOW_COPY_AND_ASSIGN(CountryNames);
 };
 
 // static
 CountryNames* CountryNames::GetInstance() {
   return Singleton<CountryNames>::get();
 }
 
-const std::string CountryNames::ApplicationLocale() {
-  if (application_locale_.empty()) {
-    // In production code, this class is always constructed on the UI thread, so
-    // the two conditions in the below DCHECK are identical.  In test code,
-    // sometimes there is a UI thread, and sometimes there is just the unnamed
-    // main thread.  Since this class is a singleton, it needs to support both
-    // cases.  Hence, the somewhat strange looking DCHECK below.
-    DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI) ||
-           thread_checker_.CalledOnValidThread());
-    application_locale_ =
-        content::GetContentClient()->browser()->GetApplicationLocale();
-  }
-
-  return application_locale_;
-}
-
 CountryNames::CountryNames() {
   // Add 2- and 3-letter ISO country codes.
   for (CountryDataMap::Iterator it = CountryDataMap::Begin();
        it != CountryDataMap::End();
        ++it) {
     const std::string& country_code = it->first;
     std::string iso3_country_code =
         icu::Locale(NULL, country_code.c_str()).getISO3Country();
 
     common_names_.insert(std::make_pair(country_code, country_code));
@@ skipping 180 matching lines @@
 
   return country_code;
 }
 
 // static
 const std::string AutofillCountry::GetCountryCode(const string16& country,
                                                   const std::string& locale) {
   return CountryNames::GetInstance()->GetCountryCode(country, locale);
 }
 
-// static
-const std::string AutofillCountry::ApplicationLocale() {
-  return CountryNames::GetInstance()->ApplicationLocale();
-}
-
 AutofillCountry::AutofillCountry(const std::string& country_code,
                                  const string16& name,
                                  const string16& postal_code_label,
                                  const string16& state_label)
     : country_code_(country_code),
       name_(name),
       postal_code_label_(postal_code_label),
       state_label_(state_label) {
 }