Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 13484002: workaround for building with express toolchain on windows (Closed)

Created:
7 years, 8 months ago by scottmg
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

workaround for building with express toolchain on windows intsafe.h and stdint.h both define INT8_MIN et al. with no guards, and so can't both be included. Because dependencies do this deep in their internals, avoid this problem by including intsafe.h, and then #undef'ing the conflicts in precompile.h (which is included in all .cc files). intsafe.h's include guard symbol stays defined so that any subsequent inclusions do not cause problems. R=thestig@chromium.org BUG=225822 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192341

Patch Set 1 #

Total comments: 1

Patch Set 2 : shorten connect link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M build/precompile.h View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scottmg
7 years, 8 months ago (2013-04-02 20:47:07 UTC) #1
Lei Zhang
I defer to mark@ and/or cpu@. https://codereview.chromium.org/13484002/diff/1/build/precompile.h File build/precompile.h (right): https://codereview.chromium.org/13484002/diff/1/build/precompile.h#newcode111 build/precompile.h:111: // http://connect.microsoft.com/VisualStudio/feedback/details/621653/including-stdint-after-intsafe-generates-warnings You ...
7 years, 8 months ago (2013-04-02 21:23:53 UTC) #2
scottmg
On 2013/04/02 21:23:53, Lei Zhang wrote: > I defer to mark@ and/or cpu@. > > ...
7 years, 8 months ago (2013-04-02 21:29:17 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
7 years, 8 months ago (2013-04-03 21:44:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/13484002/8001
7 years, 8 months ago (2013-04-04 00:10:21 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=99434
7 years, 8 months ago (2013-04-04 03:01:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/13484002/8001
7 years, 8 months ago (2013-04-04 15:14:24 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-04 16:13:46 UTC) #8
Message was sent while issue was closed.
Change committed as 192341

Powered by Google App Engine
This is Rietveld 408576698