chrome/test/data/extensions/api_test/push_messaging_canary/push_messaging_canary.js - Issue 13483025: Test code to see if a timer fixes the issue for the majority of cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/push_messaging_canary/push_messaging_canary.js

Issue 13483025: Test code to see if a timer fixes the issue for the majority of cases. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Push Messaging Canary Test Fix - Try a longer timeout Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/extensions/api_test/push_messaging_canary/push_messaging_canary.js

diff --git a/chrome/test/data/extensions/api_test/push_messaging_canary/push_messaging_canary.js b/chrome/test/data/extensions/api_test/push_messaging_canary/push_messaging_canary.js

index fd19f3caffff07f52b8dbc09fce81b574f88f664..a6759f3ef9bdbaafa552dea491c0155f7f076eb8 100644

--- a/chrome/test/data/extensions/api_test/push_messaging_canary/push_messaging_canary.js

+++ b/chrome/test/data/extensions/api_test/push_messaging_canary/push_messaging_canary.js

@@ -16,8 +16,13 @@ function verifyDetails(details) {

function startTestWithCredentials(paramClientId, paramClientSecret,

paramRefreshToken) {

+ var callbackPassFunc = chrome.test.callbackPass(verifyDetails);

chrome.pushMessaging.onMessage.addListener(

- chrome.test.callbackPass(verifyDetails));

+ function(details) {

+ // We need to allow time for the invalidation service to ACK before we

+ // shutdown.

+ window.setTimeout(callbackPassFunc(details), 20000);

+ });

clientId = paramClientId;

clientSecret = paramClientSecret;

« no previous file with comments | « chrome/test/data/extensions/api_test/push_messaging_canary/manifest.json ('k') | no next file » | no next file with comments »